Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted docs/documented-method.js to ES6 #3881

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Converted docs/documented-method.js to ES6 #3881

merged 2 commits into from
Jul 11, 2019

Conversation

abhinavsagar
Copy link
Contributor

Part of #3758

@abhinavsagar
Copy link
Contributor Author

@stalgiag Should the codebase itself be converted to ES6 ?

@stalgiag
Copy link
Contributor

Hi @abhinavsagar thanks for the offer but most of this conversion was handled by #3874. That said there will likely be further slight modifications that might need help. Feel free to follow open issues such as #3877 and #3875 to see if there are any new todos about ES6 conversion.

@stalgiag
Copy link
Contributor

I think that #3877 in particular is relevant to this particular PR. Definitely the change from var will make sense but we may use const instead of let for this type of variable.

@abhinavsagar
Copy link
Contributor Author

Thanks. I will go through the open issues.

@lmccart lmccart merged commit 99252b9 into processing:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants