Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make report() monkey patchable #5317

Merged
merged 3 commits into from Jun 18, 2021
Merged

Conversation

outofambit
Copy link
Contributor

Resolves #5243

Changes:

  • attach report() to the p5 object
  • standardize using p5._friendlyError() internally in p5 as wrapper for report()

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated

cc @catarak

@catarak
Copy link
Member

catarak commented Jun 17, 2021

thank you for working on this @outofambit!

@outofambit outofambit merged commit cfa235f into main Jun 18, 2021
@Aloneduckling
Copy link
Contributor

@outofambit, I am working on FES for GSoC'21. I have made some changes to: fes_core.js, browser_errors.js.

This PR affects the part of my code that uses the report() function. This causes the checks on the PR by GitHub to fail even though the checks on my machine are passing(my fork is not updated).

How should I proceed so that the changes I make do not create problems in p5.js's main branch?

PR: #5305

@outofambit outofambit deleted the make-report-monkey-patchable branch June 20, 2021 17:44
@outofambit
Copy link
Contributor Author

outofambit commented Jun 20, 2021

hey @Aloneduckling sorry about that! i just pushed 63ce561 to your branch, which should fix the test failures. since i changed the underlying report(), i redirected everything internal to p5 to use the already existing p5._friendlyError() (similar to in this PR). you might need to update your branch from main, before you can merge but that should be all you need. lmk if you have any questions, i'm happy to help!

@Aloneduckling
Copy link
Contributor

Aloneduckling commented Jun 21, 2021

@outofambit, thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p5.js Editor + Friendly Errors
3 participants