New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New **link(url, [winName], [options])** method! #532
Conversation
GoToLoop
commented
Feb 11, 2015
- User @leota from http://Forum.Processing.org/two/discussion/8809/link-function asked for a link() method for "p5.js".
- It already exists in PJS @ http://ProcessingJS.org/reference/link_/.
- Also in "Java Mode". But it's currently undocumented.
- I believe link()'s implementation in "p5js" was skipped somehow.
- So here it is! And it's now even more powerful w/ the extra Window features optional 3rd parameter ;-)
* User @leota from http://Forum.Processing.org/two/discussion/8809/link-function asked for a **link()** method for "p5.js". * It already exists in PJS @ http://ProcessingJS.org/reference/link_/. * Also in "Java Mode". But it's currently undocumented. * I believe **link()**'s implementation in "p5js" was skipped somehow. * So here it is! And it's now even more powerful w/ the extra Window features optional parameter ;-)
I think "link" is not a very good name for this, it is really unclear what the function would do, make an a tag? open a window? open a URL in the current window? i think the act of "linking" is making a connection, not creating a window or moving the user to a new location. It's also just reproduces the behavior of window.open with a slightly different argument list which is strange. |
|
"Most" is a stretch, but either way that doesn't mean the project should reproduce poorly named functions in processing.js. That's part of the joy of p5js not being a port, but a reinterpretation. |
|
well i can't very well respond to things in an edited comment can i ;) And yes i did read the link and see that one person wants familiarity, but for my part i'm not convinced that is sufficient. |
@GoToLoop: as @brysonian points out, the goal is to create a reinterpretation of Processing rather than a port. It is not to make a port or reimplementation or processing.js, so we are not concerned that the two fit perfectly together. Hopefully we can learn from it and make things even better. I think In the future, it would be best if you could raise an issue and we could discuss the need and implementation of a new method before submitting a PR. (See the notes under implementing a new feature here.) |