Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue labeler permissions and regex #5744

Merged
merged 2 commits into from Jul 30, 2022
Merged

Conversation

stampyzfanz
Copy link
Contributor

Fixed 2 bugs found by @Qianqianye in #5731 (comment)

Changes:

  1. The regex was relaxed to allow capital and lowercase Xs in the checkboxes and allow arbitrary whitespace between them and the issue name because issue forms have inconsistent markdown for some reason. Qianqianye noticed that Test issue labeler #5741 didn't product expected results which has been fixed in my fork.
  2. The write permission was granted to the workflow using the permissions key so that it can actually add the label. This was only added to the labeler workflow and should not impede the security of any other GitHub Actions.

Something else I noticed was a warning in the GitHub Action from the use of an undefined key enable-versioned-regex, however, the key is reccomended by the docs. Additionally, it still ends in an error message which is a known bug. However, it still works as expected and can label issues in my fork even after I reduced the permissions of the GITHUB_TOKEN to try to emulate this repository.

Just let me know if I should create an issue for this.

Screenshots of the change:

PR Checklist

@Qianqianye Qianqianye merged commit 9f3a739 into processing:main Jul 30, 2022
@Qianqianye
Copy link
Contributor

Thank you @stampyzfanz! I did a test in issue #5745 and the labels totally worked. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants