Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5939
Changes:
There is a small API change that prevents mocha from exiting correctly which has been fixed. As such mocha has been updated to the latest version.
Also to note is that NPM has finally fixed the install bug that prevents up from upgrading node version and now with node 18 and npm 8.19.3, the install works fully. I haven't test which precise version of npm start to have the fix but in any case we don't have to suggest node 14 anymore and just skip to node 18.
package-lock.json
has been regenerated accordingly.PR Checklist
npm run lint
passes