Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha to latest version #5944

Merged
merged 1 commit into from Jan 9, 2023
Merged

Conversation

limzykenneth
Copy link
Member

Addresses #5939

Changes:

There is a small API change that prevents mocha from exiting correctly which has been fixed. As such mocha has been updated to the latest version.

Also to note is that NPM has finally fixed the install bug that prevents up from upgrading node version and now with node 18 and npm 8.19.3, the install works fully. I haven't test which precise version of npm start to have the fix but in any case we don't have to suggest node 14 anymore and just skip to node 18. package-lock.json has been regenerated accordingly.

PR Checklist

@Qianqianye
Copy link
Contributor

Thanks @limzykenneth!

Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Just checked it out, looks good!

@Qianqianye Qianqianye merged commit bb97f3d into processing:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants