Do not use angleBetween() for angle calculation in _orbit() inside orbtiControl().

[inaridarkfox4231]

Since angleBetween() can return negative numbers, modify it so that it only returns positive numbers.
This function is not used because it is inconvenient to be affected by the specification change of angleBetween().

Resolves #6153

Changes:

before:

  // Find the angle between the "up" and the "front", add dPhi to that.
  const camPhi = front.angleBetween(up) + dPhi;

after:

  // Find the angle between the "up" and the "front", add dPhi to that.
  const camPhi =
    Math.acos(Math.max(-1, Math.min(1, p5.Vector.dot(front, up)))) + dPhi;

PR Checklist

• npm run lint passes
• Inline documentation is included / updated
• Unit tests are included / updated

[inaridarkfox4231]

The idea of ​​executing angleBetween() with abs cannot be adopted.
This is because functions that are signed or unsigned for unreasonable reasons cannot be trusted.

[davepagurek]

Makes sense, can we add a comment explaining what this does differently from angleBetween for context for future readers?

[inaridarkfox4231]

"Since the specifications of angleBetween() are subject to change due to version updates, a calculation method that directly obtains the angle between two vectors is used here."
How about this?

[inaridarkfox4231]

Should I mention the possibility of getting negative numbers?
"angleBetween() can return negative numbers. Since this specification is subject to change due to version updates, it cannot be adopted, so here we calculate using a method that directly obtains the absolute value."
Is this better?

[davepagurek]

I think mentioning negative numbers is good, since that's main motivation and the bit that would cause a bug (and using a separate implementation instead of abs() just makes it a bit more efficient and less likely to break in the future.) Your text looks good!

[inaridarkfox4231]

Perhaps it would be more reliable to enclose acos with abs, but it would be complicated and I don't think the javascript specification will change so much, so I think this is fine.

[inaridarkfox4231]

Thanks so much! ('ω')