Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing chainable/doc. #6209

Merged
merged 3 commits into from Jun 22, 2023
Merged

add missing chainable/doc. #6209

merged 3 commits into from Jun 22, 2023

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Jun 14, 2023 •
edited

Resolves #6208 , p5-types/p5.ts#58

Changes:

  1. add @chainable to doubleClicked 's doc.
  2. move/add some doc to properly place.

It's strange that p5.Element = class Element { doesn't work but p5.Element = class { works.

Screenshots of the change:

PR Checklist

@asukaminato0721 asukaminato0721 marked this pull request as draft June 14, 2023 07:07
@asukaminato0721 asukaminato0721 marked this pull request as ready for review June 14, 2023 07:37
@asukaminato0721 asukaminato0721 marked this pull request as draft June 15, 2023 16:25
@asukaminato0721 asukaminato0721 marked this pull request as ready for review June 15, 2023 17:10
@asukaminato0721 asukaminato0721 changed the title add missing chainable/doc && better ide support. add missing chainable/doc. Jun 15, 2023
davepagurek
davepagurek approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these doc comments!

@davepagurek davepagurek merged commit 6774abc into processing:main Jun 22, 2023
5 checks passed
@asukaminato0721 asukaminato0721 mentioned this pull request Jun 22, 2023
Closed
3 tasks
@asukaminato0721 asukaminato0721 deleted the miss-chainable branch June 22, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepagurek davepagurek davepagurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p5.Element doubleClicked missing @chainable in doc.
3 participants
@asukaminato0721 @davepagurek @limzykenneth