Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for pde:// browser protocol (LINUX) #696

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

peonix0
Copy link

@peonix0 peonix0 commented Apr 6, 2023

I have added the support of pde:// browser protocol for linux(Fixes: #674 )
which enables the opening of *.pde file from web URLs using the pde:// protocol.

as from previous PR#689 discussion, we still have two undesired behavior-

  1. on executing xdg-open pde:///path/to/sketchbook/SimpleExport/SimpleExport.pde it open ups two different window, one with desired file other one with empty file.

  2. on visiting xdg-open pde://sableraf.github.io/testURIscheme/sketchBundle.pdez it opens sketchBundle.pdez only if processing is already in run.

@SableRaf
Copy link
Contributor

SableRaf commented May 2, 2023

Thanks @lala-lala-lori! Please note that merging your PR may take a little while as we work through other issues. Thanks for your contribution.

@SableRaf
Copy link
Contributor

SableRaf commented May 4, 2023

cc @evan-goode since you weighed in on the previous version of this contribution, would you mind having a look at this new Pull Request? Thanks!

@evan-goode
Copy link

LGTM!
These underlying cause of these issues

on executing xdg-open pde:///path/to/sketchbook/SimpleExport/SimpleExport.pde it open ups two different window, one with desired file other one with empty file.

on visiting xdg-open pde://sableraf.github.io/testURIscheme/sketchBundle.pdez it opens sketchBundle.pdez only if processing is already in run.

seem to be unrelated to the changes made in this PR.

@sampottinger
Copy link
Collaborator

Thanks for this contribution @lala-lala-lori !

@benfry
Copy link
Owner

benfry commented Jul 26, 2023

Awesome, thank you! This is merged for 4.3.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register pde:// browser protocol for .pdez and .pdex files on Linux
5 participants