Skip to content

Commit

Permalink
Grab new p1_utils that has fix for R19
Browse files Browse the repository at this point in the history
  • Loading branch information
@prefiks
prefiks committed Jul 1, 2016
1 parent 0737958 commit 16b1d85
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rebar.config
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
%%%-------------------------------------------------------------------

{deps, [{lager, ".*", {git, "https://github.com/basho/lager", {tag, "3.2.1"}}},
{p1_utils, ".*", {git, "https://github.com/processone/p1_utils", {tag, "1.0.4"}}},
{p1_utils, ".*", {git, "https://github.com/processone/p1_utils", {tag, "1.0.5"}}},
{cache_tab, ".*", {git, "https://github.com/processone/cache_tab", {tag, "1.0.3"}}},
{fast_tls, ".*", {git, "https://github.com/processone/fast_tls", {tag, "1.0.5"}}},
{stringprep, ".*", {git, "https://github.com/processone/stringprep", {tag, "1.0.4"}}},
Expand Down

2 comments on commit 16b1d85

@marinakr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have trouble with p1_utils 1.0.5 - ejabberd 16.06
It waits for fast_xml, but p1_fsm implicitly call xml:.... wich waits for p1_fsm
So now I have fast_xml and p1_xml in deps

@prefiks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems we forgot to update some deps of ours deps in that release, and with how rebar handles dependences versioning it may leads to some strange things. We really can't do much more for old releases.

I think that executing "rebar skip_deps=true update-deps" in ejabberd main dir will likely grab correct version of p1_utils, but you newer can be sure with rebar version resolving code.

Please sign in to comment.