Warn on cyclic modules dependencies

processone · Jul 7, 2016 · c718cbb · c718cbb
1 parent 12c0d88
commit c718cbb
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/gen_mod.erl b/src/gen_mod.erl
@@ -111,7 +111,14 @@ sort_modules(Host, ModOpts) ->
 					     [DepMod, Mod]);
 			    {DepMod, DepOpts} ->
 				digraph:add_vertex(G, DepMod, DepOpts),
-				digraph:add_edge(G, DepMod, Mod)
+				case digraph:add_edge(G, DepMod, Mod) of
+				    {error, {bad_edge, Path}} ->
+					?WARNING_MSG("cyclic dependency detected "
+						     "between modules: ~p",
+						     [Path]);
+				    _ ->
+					ok
+				end
 			end
 		end, Deps)
       end, ModOpts),