Additional hooks for module_install, module_uninstall

[iAchilles]

Hi guys!
Are there any ways (hooks) to run custom logic before/after module install (before/after module uninstall) ?

[cromain]

There is nothing for this now. Adding hook would be simple, but only a custom ejabberd module would catch this and run your custom logic.
I mean, this would be usefull only if you write your own module which triggers action on the hooks.

[iAchilles]

@cromain
Yes, I often write custom modules for eJabberd, and it would be great if module_install calls hook handler in the module automatically :-)

For example:
src/ext_mod.erl

install(Module) when is_atom(Module) ->
    install(jlib:atom_to_binary(Module));
install(Package) when is_binary(Package) ->
    Spec = [S || {Mod, S} <- available(), jlib:atom_to_binary(Mod)==Package],
    case {Spec, installed(Package), is_contrib_allowed()} of
        {_, _, false} ->
            {error, not_allowed};
        {[], _, _} ->
            {error, not_available};
        {_, true, _} ->
            {error, conflict};
        {[Attrs], _, _} ->
            Module = jlib:binary_to_atom(Package),
            case compile_and_install(Module, Attrs) of
                ok ->
                    code:add_patha(module_ebin_dir(Module)),
                    ejabberd_config:reload_file(),

                    case erlang:function_exported(Module, post_install, 0) of
                          true ->
                               Module:post_install(); 
                          _ ->
                               ok
                     end;

                Error ->
                    delete_path(module_lib_dir(Module)),
                    Error
            end
    end.

[cromain]

This is indeed a good approach. It's now committed. Thanks.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.