Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod_push - empty notification stanza (no sender, no message body) when chatting group #3651

Closed
dongnguyen7 opened this issue Jul 28, 2021 · 3 comments
Closed

mod_push - empty notification stanza (no sender, no message body) when chatting group #3651

dongnguyen7 opened this issue Jul 28, 2021 · 3 comments
Milestone
ejabberd 21.12

Comments

@dongnguyen7
Copy link

dongnguyen7 commented Jul 28, 2021 •
edited
Loading

Environment

  • ejabberd version: 21.7.0
  • OS: Windows
  • Docker - ejabberd/ecs

Configuration

listen:
  -
    port: 5347
    module: ejabberd_service
    access: all
    shaper_rule: fast
    ip: "::"
    hosts:
      "p2.dong.tld":
        password: "verysecure"
...
  mod_muc:
    access:
      - allow
    access_admin:
      - allow: admin
    access_create: admin
    access_persistent: admin
    access_mam:
      - allow
    default_room_options:
      allow_subscription: true
      mam: true
      members_only: true
      persistent: true
      public: false
      public_list: false
  mod_offline:
    access_max_user_messages: max_user_offline_messages
  mod_pubsub:
    access_createnode: pubsub_createnode
    plugins:
      - flat
      - pep
    force_node_config:
      storage:bookmarks:
        access_model: whitelist
  mod_push:
    include_sender: false
    include_body: true
  ##mod_push_keepalive: {}

Errors from error.log/crash.log

the relevant debug log

2021-07-28 14:01:10.861668+00:00 [debug] <0.987.0>@ejabberd_shaper:update/2:75 Shaper update:
#state{maxrate = 1000,burst_size = 1000,acquired_credit = 987,
       lasttime = 1627480861964455} =>
{#state{maxrate = 1000,burst_size = 1000,acquired_credit = 1000,
        lasttime = 1627480870861579},
 0}
2021-07-28 14:01:10.862343+00:00 [notice] <0.989.0> (websocket|<0.988.0>) Received XML on stream = <<"<message xmlns='jabber:client' from='customer-2901@db/converse.js-135378902' id='07baab7e-6215-4c37-9443-3ba090e9dc71' to='room_1@conference.db' type='groupchat'><body>asdfadsfasdfsdf</body><active xmlns='http://jabber.org/protocol/chatstates'/><origin-id xmlns='urn:xmpp:sid:0' id='07baab7e-6215-4c37-9443-3ba090e9dc71'/></message>">>
2021-07-28 14:01:10.863082+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_recv: mod_stream_mgmt:c2s_handle_recv/3
2021-07-28 14:01:10.863357+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_authenticated_packet: mod_client_state:c2s_authenticated_packet/2
2021-07-28 14:01:10.863724+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_authenticated_packet: mod_stream_mgmt:c2s_authenticated_packet/2
2021-07-28 14:01:10.863937+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_send_packet: mod_privacy:user_send_packet/1
2021-07-28 14:01:10.864246+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_send_packet: mod_vcard_xupdate:user_send_packet/1
2021-07-28 14:01:10.864478+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_send_packet: mod_caps:user_send_packet/1
2021-07-28 14:01:10.864856+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_send_packet: mod_mam:user_send_packet/1
2021-07-28 14:01:10.865080+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_send_packet: mod_carboncopy:user_send_packet/1
2021-07-28 14:01:10.865266+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_send_packet: mod_mam:user_send_packet_strip_tag/1
2021-07-28 14:01:10.865483+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook privacy_check_packet: mod_last:privacy_check_packet/4
2021-07-28 14:01:10.865699+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook privacy_check_packet: mod_privacy:check_packet/4
2021-07-28 14:01:10.866212+00:00 [debug] <0.989.0>@ejabberd_router:do_route/1:384 Route:
#message{id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
         lang = <<"en">>,
         from = #jid{user = <<"customer-2901">>,server = <<"db">>,
                     resource = <<"converse.js-135378902">>,
                     luser = <<"customer-2901">>,lserver = <<"db">>,
                     lresource = <<"converse.js-135378902">>},
         to = #jid{user = <<"room_1">>,server = <<"conference.db">>,
                   resource = <<>>,luser = <<"room_1">>,
                   lserver = <<"conference.db">>,lresource = <<>>},
         subject = [],
         body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
         thread = undefined,
         sub_els = [#xmlel{name = <<"active">>,
                           attrs = [{<<"xmlns">>,
                                     <<"http://jabber.org/protocol/chatstates">>}],
                           children = []},
                    #xmlel{name = <<"origin-id">>,
                           attrs = [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                                    {<<"id">>,
                                     <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
                           children = []}],
         meta = #{ip => {0,0,0,0,0,65535,2570,1}}}
2021-07-28 14:01:10.867430+00:00 [debug] <0.989.0>@mod_muc_room:route/2:928 Routing to MUC room <0.912.0>:
#message{id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
         lang = <<"en">>,
         from = #jid{user = <<"customer-2901">>,server = <<"db">>,
                     resource = <<"converse.js-135378902">>,
                     luser = <<"customer-2901">>,lserver = <<"db">>,
                     lresource = <<"converse.js-135378902">>},
         to = #jid{user = <<"room_1">>,server = <<"conference.db">>,
                   resource = <<>>,luser = <<"room_1">>,
                   lserver = <<"conference.db">>,lresource = <<>>},
         subject = [],
         body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
         thread = undefined,
         sub_els = [#xmlel{name = <<"active">>,
                           attrs = [{<<"xmlns">>,
                                     <<"http://jabber.org/protocol/chatstates">>}],
                           children = []},
                    #xmlel{name = <<"origin-id">>,
                           attrs = [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                                    {<<"id">>,
                                     <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
                           children = []}],
         meta = #{ip => {0,0,0,0,0,65535,2570,1}}}
2021-07-28 14:01:10.868977+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook muc_filter_message: mod_mam:muc_filter_message/3
2021-07-28 14:01:10.869313+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook store_mam_message: mod_push:mam_message/7
2021-07-28 14:01:10.869654+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook store_mam_message: mod_mam:store_mam_message/7
2021-07-28 14:01:10.883243+00:00 [debug] <0.912.0>@ejabberd_router_multicast:do_route/4:244 Route multicast:
#message{
    id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
    lang = <<"en">>,
    from =
        #jid{
            user = <<"room_1">>,server = <<"conference.db">>,
            resource = <<"customer">>,luser = <<"room_1">>,
            lserver = <<"conference.db">>,lresource = <<"customer">>},
    to =
        #jid{
            user = <<"room_1">>,server = <<"conference.db">>,resource = <<>>,
            luser = <<"room_1">>,lserver = <<"conference.db">>,
            lresource = <<>>},
    subject = [],
    body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
    thread = undefined,
    sub_els =
        [#mam_archived{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #stanza_id{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #xmlel{
             name = <<"active">>,
             attrs =
                 [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
             children = []},
         #xmlel{
             name = <<"origin-id">>,
             attrs =
                 [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                  {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
             children = []}],
    meta =
        #{ip => {0,0,0,0,0,65535,2570,1},
          mam_archived => true,
          muc_sender_real_jid =>
              #jid{
                  user = <<"customer-2901">>,server = <<"db">>,
                  resource = <<"converse.js-135378902">>,
                  luser = <<"customer-2901">>,lserver = <<"db">>,
                  lresource = <<"converse.js-135378902">>},
          stanza_id => 1627480870869265}}
Domain: db
Destinations: customer-2901@db/converse.js-135378902

2021-07-28 14:01:10.884306+00:00 [debug] <0.912.0>@ejabberd_router:do_route/1:384 Route:
#message{
    id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
    lang = <<"en">>,
    from =
        #jid{
            user = <<"room_1">>,server = <<"conference.db">>,
            resource = <<"customer">>,luser = <<"room_1">>,
            lserver = <<"conference.db">>,lresource = <<"customer">>},
    to =
        #jid{
            user = <<"customer-2901">>,server = <<"db">>,
            resource = <<"converse.js-135378902">>,
            luser = <<"customer-2901">>,lserver = <<"db">>,
            lresource = <<"converse.js-135378902">>},
    subject = [],
    body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
    thread = undefined,
    sub_els =
        [#mam_archived{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #stanza_id{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #xmlel{
             name = <<"active">>,
             attrs =
                 [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
             children = []},
         #xmlel{
             name = <<"origin-id">>,
             attrs =
                 [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                  {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
             children = []}],
    meta =
        #{ip => {0,0,0,0,0,65535,2570,1},
          mam_archived => true,
          muc_sender_real_jid =>
              #jid{
                  user = <<"customer-2901">>,server = <<"db">>,
                  resource = <<"converse.js-135378902">>,
                  luser = <<"customer-2901">>,lserver = <<"db">>,
                  lresource = <<"converse.js-135378902">>},
          stanza_id => 1627480870869265}}
2021-07-28 14:01:10.885818+00:00 [debug] <0.912.0>@ejabberd_local:route/1:74 Local route:
#message{
    id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
    lang = <<"en">>,
    from =
        #jid{
            user = <<"room_1">>,server = <<"conference.db">>,
            resource = <<"customer">>,luser = <<"room_1">>,
            lserver = <<"conference.db">>,lresource = <<"customer">>},
    to =
        #jid{
            user = <<"customer-2901">>,server = <<"db">>,
            resource = <<"converse.js-135378902">>,
            luser = <<"customer-2901">>,lserver = <<"db">>,
            lresource = <<"converse.js-135378902">>},
    subject = [],
    body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
    thread = undefined,
    sub_els =
        [#mam_archived{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #stanza_id{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #xmlel{
             name = <<"active">>,
             attrs =
                 [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
             children = []},
         #xmlel{
             name = <<"origin-id">>,
             attrs =
                 [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                  {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
             children = []}],
    meta =
        #{ip => {0,0,0,0,0,65535,2570,1},
          mam_archived => true,
          muc_sender_real_jid =>
              #jid{
                  user = <<"customer-2901">>,server = <<"db">>,
                  resource = <<"converse.js-135378902">>,
                  luser = <<"customer-2901">>,lserver = <<"db">>,
                  lresource = <<"converse.js-135378902">>},
          stanza_id => 1627480870869265}}
2021-07-28 14:01:10.886652+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook sm_receive_packet: mod_mam:sm_receive_packet/1
2021-07-28 14:01:10.887408+00:00 [debug] <0.912.0>@ejabberd_sm:do_route/1:719 Processing packet to full JID:
#message{
    id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
    lang = <<"en">>,
    from =
        #jid{
            user = <<"room_1">>,server = <<"conference.db">>,
            resource = <<"customer">>,luser = <<"room_1">>,
            lserver = <<"conference.db">>,lresource = <<"customer">>},
    to =
        #jid{
            user = <<"customer-2901">>,server = <<"db">>,
            resource = <<"converse.js-135378902">>,
            luser = <<"customer-2901">>,lserver = <<"db">>,
            lresource = <<"converse.js-135378902">>},
    subject = [],
    body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
    thread = undefined,
    sub_els =
        [#mam_archived{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #stanza_id{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #xmlel{
             name = <<"active">>,
             attrs =
                 [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
             children = []},
         #xmlel{
             name = <<"origin-id">>,
             attrs =
                 [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                  {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
             children = []}],
    meta =
        #{ip => {0,0,0,0,0,65535,2570,1},
          mam_archived => true,
          muc_sender_real_jid =>
              #jid{
                  user = <<"customer-2901">>,server = <<"db">>,
                  resource = <<"converse.js-135378902">>,
                  luser = <<"customer-2901">>,lserver = <<"db">>,
                  lresource = <<"converse.js-135378902">>},
          stanza_id => 1627480870869265}}
2021-07-28 14:01:10.889101+00:00 [debug] <0.912.0>@ejabberd_sm:do_route/1:741 Sending to process <0.989.0>:
#message{
    id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
    lang = <<"en">>,
    from =
        #jid{
            user = <<"room_1">>,server = <<"conference.db">>,
            resource = <<"customer">>,luser = <<"room_1">>,
            lserver = <<"conference.db">>,lresource = <<"customer">>},
    to =
        #jid{
            user = <<"customer-2901">>,server = <<"db">>,
            resource = <<"converse.js-135378902">>,
            luser = <<"customer-2901">>,lserver = <<"db">>,
            lresource = <<"converse.js-135378902">>},
    subject = [],
    body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
    thread = undefined,
    sub_els =
        [#mam_archived{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #stanza_id{
             by =
                 #jid{
                     user = <<"room_1">>,server = <<"conference.db">>,
                     resource = <<>>,luser = <<"room_1">>,
                     lserver = <<"conference.db">>,lresource = <<>>},
             id = <<"1627480870869265">>},
         #xmlel{
             name = <<"active">>,
             attrs =
                 [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
             children = []},
         #xmlel{
             name = <<"origin-id">>,
             attrs =
                 [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                  {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
             children = []}],
    meta =
        #{ip => {0,0,0,0,0,65535,2570,1},
          mam_archived => true,
          muc_sender_real_jid =>
              #jid{
                  user = <<"customer-2901">>,server = <<"db">>,
                  resource = <<"converse.js-135378902">>,
                  luser = <<"customer-2901">>,lserver = <<"db">>,
                  lresource = <<"converse.js-135378902">>},
          stanza_id => 1627480870869265}}
2021-07-28 14:01:10.890112+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_info: ejabberd_sm:c2s_handle_info/2
2021-07-28 14:01:10.890404+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_info: mod_offline:c2s_handle_info/2
2021-07-28 14:01:10.890629+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_info: mod_pubsub:c2s_handle_info/2
2021-07-28 14:01:10.890762+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_info: mod_stream_mgmt:c2s_handle_info/2
2021-07-28 14:01:10.890522+00:00 [debug] <0.912.0>@ejabberd_router_multicast:do_route/4:235 Route multicast:
#message{
 id = <<"1627480870869265">>,type = normal,lang = <<>>,
 from =
  #jid{
   user = <<"room_1">>,server = <<"conference.db">>,resource = <<>>,
   luser = <<"room_1">>,lserver = <<"conference.db">>,lresource = <<>>},
 to = undefined,subject = [],body = [],thread = undefined,
 sub_els =
  [#ps_event{
    items =
     #ps_items{
      xmlns = <<>>,node = <<"urn:xmpp:mucsub:nodes:messages">>,
      items =
       [#ps_item{
         xmlns = <<>>,id = <<"1627480870869265">>,
         sub_els =
          [#message{
            id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
            lang = <<"en">>,
            from =
             #jid{
              user = <<"room_1">>,server = <<"conference.db">>,
              resource = <<"customer">>,luser = <<"room_1">>,
              lserver = <<"conference.db">>,lresource = <<"customer">>},
            to = undefined,subject = [],
            body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
            thread = undefined,
            sub_els =
             [#mam_archived{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #stanza_id{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #xmlel{
               name = <<"active">>,
               attrs =
                [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
               children = []},
              #xmlel{
               name = <<"origin-id">>,
               attrs =
                [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                 {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
               children = []}],
            meta =
             #{ip => {0,0,0,0,0,65535,2570,1},
               mam_archived => true,
               muc_sender_real_jid =>
                #jid{
                 user = <<"customer-2901">>,server = <<"db">>,
                 resource = <<"converse.js-135378902">>,
                 luser = <<"customer-2901">>,lserver = <<"db">>,
                 lresource = <<"converse.js-135378902">>},
               stanza_id => 1627480870869265}}],
         node = <<>>,publisher = <<>>}],
      max_items = undefined,subid = <<>>,retract = undefined},
    purge = undefined,subscription = undefined,delete = undefined,
    create = undefined,configuration = undefined}],
 meta = #{in_muc_mam => true}}
Domain: db
Destinations: driver-9448@db

2021-07-28 14:01:10.890916+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_info: ejabberd_c2s:process_info/2
2021-07-28 14:01:10.891258+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook privacy_check_packet: mod_last:privacy_check_packet/4
2021-07-28 14:01:10.891468+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook privacy_check_packet: mod_privacy:check_packet/4
2021-07-28 14:01:10.891762+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_receive_packet: mod_caps:user_receive_packet/1
2021-07-28 14:01:10.892003+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_receive_packet: mod_mam:user_receive_packet/1
2021-07-28 14:01:10.891785+00:00 [debug] <0.912.0>@ejabberd_router:do_route/1:384 Route:
#message{
 id = <<"1627480870869265">>,type = normal,lang = <<>>,
 from =
  #jid{
   user = <<"room_1">>,server = <<"conference.db">>,resource = <<>>,
   luser = <<"room_1">>,lserver = <<"conference.db">>,lresource = <<>>},
 to =
  #jid{
   user = <<"driver-9448">>,server = <<"db">>,resource = <<>>,
   luser = <<"driver-9448">>,lserver = <<"db">>,lresource = <<>>},
 subject = [],body = [],thread = undefined,
 sub_els =
  [#ps_event{
    items =
     #ps_items{
      xmlns = <<>>,node = <<"urn:xmpp:mucsub:nodes:messages">>,
      items =
       [#ps_item{
         xmlns = <<>>,id = <<"1627480870869265">>,
         sub_els =
          [#message{
            id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
            lang = <<"en">>,
            from =
             #jid{
              user = <<"room_1">>,server = <<"conference.db">>,
              resource = <<"customer">>,luser = <<"room_1">>,
              lserver = <<"conference.db">>,lresource = <<"customer">>},
            to =
             #jid{
              user = <<"driver-9448">>,server = <<"db">>,resource = <<>>,
              luser = <<"driver-9448">>,lserver = <<"db">>,lresource = <<>>},
            subject = [],
            body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
            thread = undefined,
            sub_els =
             [#mam_archived{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #stanza_id{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #xmlel{
               name = <<"active">>,
               attrs =
                [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
               children = []},
              #xmlel{
               name = <<"origin-id">>,
               attrs =
                [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                 {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
               children = []}],
            meta =
             #{ip => {0,0,0,0,0,65535,2570,1},
               mam_archived => true,
               muc_sender_real_jid =>
                #jid{
                 user = <<"customer-2901">>,server = <<"db">>,
                 resource = <<"converse.js-135378902">>,
                 luser = <<"customer-2901">>,lserver = <<"db">>,
                 lresource = <<"converse.js-135378902">>},
               stanza_id => 1627480870869265}}],
         node = <<>>,publisher = <<>>}],
      max_items = undefined,subid = <<>>,retract = undefined},
    purge = undefined,subscription = undefined,delete = undefined,
    create = undefined,configuration = undefined}],
 meta = #{in_muc_mam => true}}
2021-07-28 14:01:10.892225+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook user_receive_packet: mod_carboncopy:user_receive_packet/1
2021-07-28 14:01:10.892568+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_chat_states/1
2021-07-28 14:01:10.892776+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_pep/1
2021-07-28 14:01:10.892997+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_presence/1
2021-07-28 14:01:10.893169+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_other/1
2021-07-28 14:01:10.893367+00:00 [debug] <0.989.0>@mod_client_state:filter_other/1:314 Won't add stanza for customer-2901@db/converse.js-135378902 to CSI queue
2021-07-28 14:01:10.893142+00:00 [debug] <0.912.0>@ejabberd_local:route/1:74 Local route:
#message{
 id = <<"1627480870869265">>,type = normal,lang = <<>>,
 from =
  #jid{
   user = <<"room_1">>,server = <<"conference.db">>,resource = <<>>,
   luser = <<"room_1">>,lserver = <<"conference.db">>,lresource = <<>>},
 to =
  #jid{
   user = <<"driver-9448">>,server = <<"db">>,resource = <<>>,
   luser = <<"driver-9448">>,lserver = <<"db">>,lresource = <<>>},
 subject = [],body = [],thread = undefined,
 sub_els =
  [#ps_event{
    items =
     #ps_items{
      xmlns = <<>>,node = <<"urn:xmpp:mucsub:nodes:messages">>,
      items =
       [#ps_item{
         xmlns = <<>>,id = <<"1627480870869265">>,
         sub_els =
          [#message{
            id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
            lang = <<"en">>,
            from =
             #jid{
              user = <<"room_1">>,server = <<"conference.db">>,
              resource = <<"customer">>,luser = <<"room_1">>,
              lserver = <<"conference.db">>,lresource = <<"customer">>},
            to =
             #jid{
              user = <<"driver-9448">>,server = <<"db">>,resource = <<>>,
              luser = <<"driver-9448">>,lserver = <<"db">>,lresource = <<>>},
            subject = [],
            body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
            thread = undefined,
            sub_els =
             [#mam_archived{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #stanza_id{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #xmlel{
               name = <<"active">>,
               attrs =
                [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
               children = []},
              #xmlel{
               name = <<"origin-id">>,
               attrs =
                [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                 {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
               children = []}],
            meta =
             #{ip => {0,0,0,0,0,65535,2570,1},
               mam_archived => true,
               muc_sender_real_jid =>
                #jid{
                 user = <<"customer-2901">>,server = <<"db">>,
                 resource = <<"converse.js-135378902">>,
                 luser = <<"customer-2901">>,lserver = <<"db">>,
                 lresource = <<"converse.js-135378902">>},
               stanza_id => 1627480870869265}}],
         node = <<>>,publisher = <<>>}],
      max_items = undefined,subid = <<>>,retract = undefined},
    purge = undefined,subscription = undefined,delete = undefined,
    create = undefined,configuration = undefined}],
 meta = #{in_muc_mam => true}}
2021-07-28 14:01:10.893612+00:00 [debug] <0.989.0>@mod_client_state:dequeue_sender/2:365 Flushing packets of room_1@conference.db from CSI queue of customer-2901@db/converse.js-135378902
2021-07-28 14:01:10.893936+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook sm_receive_packet: mod_mam:sm_receive_packet/1
2021-07-28 14:01:10.893994+00:00 [notice] <0.989.0> (websocket|<0.988.0>) Send XML on stream = <<"<message xml:lang='en' to='customer-2901@db/converse.js-135378902' from='room_1@conference.db/customer' type='groupchat' id='07baab7e-6215-4c37-9443-3ba090e9dc71'><archived by='room_1@conference.db' id='1627480870869265' xmlns='urn:xmpp:mam:tmp'/><stanza-id by='room_1@conference.db' id='1627480870869265' xmlns='urn:xmpp:sid:0'/><active xmlns='http://jabber.org/protocol/chatstates'/><origin-id xmlns='urn:xmpp:sid:0' id='07baab7e-6215-4c37-9443-3ba090e9dc71'/><body>asdfadsfasdfsdf</body></message>">>
2021-07-28 14:01:10.894665+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_send: mod_push:c2s_stanza/3
2021-07-28 14:01:10.894471+00:00 [debug] <0.912.0>@ejabberd_sm:do_route/1:703 Processing message to bare JID:
#message{
 id = <<"1627480870869265">>,type = normal,lang = <<>>,
 from =
  #jid{
   user = <<"room_1">>,server = <<"conference.db">>,resource = <<>>,
   luser = <<"room_1">>,lserver = <<"conference.db">>,lresource = <<>>},
 to =
  #jid{
   user = <<"driver-9448">>,server = <<"db">>,resource = <<>>,
   luser = <<"driver-9448">>,lserver = <<"db">>,lresource = <<>>},
 subject = [],body = [],thread = undefined,
 sub_els =
  [#ps_event{
    items =
     #ps_items{
      xmlns = <<>>,node = <<"urn:xmpp:mucsub:nodes:messages">>,
      items =
       [#ps_item{
         xmlns = <<>>,id = <<"1627480870869265">>,
         sub_els =
          [#message{
            id = <<"07baab7e-6215-4c37-9443-3ba090e9dc71">>,type = groupchat,
            lang = <<"en">>,
            from =
             #jid{
              user = <<"room_1">>,server = <<"conference.db">>,
              resource = <<"customer">>,luser = <<"room_1">>,
              lserver = <<"conference.db">>,lresource = <<"customer">>},
            to =
             #jid{
              user = <<"driver-9448">>,server = <<"db">>,resource = <<>>,
              luser = <<"driver-9448">>,lserver = <<"db">>,lresource = <<>>},
            subject = [],
            body = [#text{lang = <<>>,data = <<"asdfadsfasdfsdf">>}],
            thread = undefined,
            sub_els =
             [#mam_archived{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #stanza_id{
               by =
                #jid{
                 user = <<"room_1">>,server = <<"conference.db">>,
                 resource = <<>>,luser = <<"room_1">>,
                 lserver = <<"conference.db">>,lresource = <<>>},
               id = <<"1627480870869265">>},
              #xmlel{
               name = <<"active">>,
               attrs =
                [{<<"xmlns">>,<<"http://jabber.org/protocol/chatstates">>}],
               children = []},
              #xmlel{
               name = <<"origin-id">>,
               attrs =
                [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
                 {<<"id">>,<<"07baab7e-6215-4c37-9443-3ba090e9dc71">>}],
               children = []}],
            meta =
             #{ip => {0,0,0,0,0,65535,2570,1},
               mam_archived => true,
               muc_sender_real_jid =>
                #jid{
                 user = <<"customer-2901">>,server = <<"db">>,
                 resource = <<"converse.js-135378902">>,
                 luser = <<"customer-2901">>,lserver = <<"db">>,
                 lresource = <<"converse.js-135378902">>},
               stanza_id => 1627480870869265}}],
         node = <<>>,publisher = <<>>}],
      max_items = undefined,subid = <<>>,retract = undefined},
    purge = undefined,subscription = undefined,delete = undefined,
    create = undefined,configuration = undefined}],
 meta = #{in_muc_mam => true,stanza_id => 1627480870894062}}
2021-07-28 14:01:10.894853+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_send: mod_stream_mgmt:c2s_handle_send/3
2021-07-28 14:01:10.895091+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_chat_states/1
2021-07-28 14:01:10.895305+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_pep/1
2021-07-28 14:01:10.895488+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook privacy_check_packet: mod_last:privacy_check_packet/4
2021-07-28 14:01:10.895483+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_presence/1
2021-07-28 14:01:10.895688+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_filter_send: mod_client_state:filter_other/1
2021-07-28 14:01:10.895858+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook privacy_check_packet: mod_privacy:check_packet/4
2021-07-28 14:01:10.896033+00:00 [notice] <0.989.0> (websocket|<0.988.0>) Send XML on stream = <<"<r xmlns='urn:xmpp:sm:3'/>">>
2021-07-28 14:01:10.896183+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook offline_message_hook: mod_mam:offline_message/1
2021-07-28 14:01:10.896536+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook store_mam_message: mod_push:mam_message/7
2021-07-28 14:01:10.896617+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_send: mod_push:c2s_stanza/3
2021-07-28 14:01:10.896761+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_send: mod_stream_mgmt:c2s_handle_send/3
2021-07-28 14:01:10.896817+00:00 [debug] <0.912.0>@mod_push:mam_message/7:420 Notifying driver-9448@db of MAM message
2021-07-28 14:01:10.897810+00:00 [debug] <0.912.0>@ejabberd_router:do_route/1:384 Route:
#iq{id =
        <<"rr-1627480902897-12131238736936548073-IcZtR92rQos+mpZzPMsXFcBd2sI=-126253382">>,
    type = set,lang = <<>>,
    from =
        #jid{
            user = <<>>,server = <<"db">>,resource = <<>>,luser = <<>>,
            lserver = <<"db">>,lresource = <<>>},
    to =
        #jid{
            user = <<>>,server = <<"p2.dong.tld">>,resource = <<>>,
            luser = <<>>,lserver = <<"p2.dong.tld">>,lresource = <<>>},
    sub_els =
        [#pubsub{
             subscriptions = undefined,subscription = undefined,
             affiliations = undefined,
             publish =
                 #ps_publish{
                     node = <<"6bwEllwfFHhP">>,
                     items =
                         [#ps_item{
                              xmlns = <<>>,id = <<>>,
                              sub_els =
                                  [#push_notification{xdata = undefined}],
                              node = <<>>,publisher = <<>>}]},
             publish_options =
                 #xdata{
                     type = submit,instructions = [],title = undefined,
                     reported = undefined,items = [],
                     fields =
                         [#xdata_field{
                              label = <<>>,type = undefined,
                              var = <<"FORM_TYPE">>,required = false,
                              desc = <<>>,
                              values =
                                  [<<"http://jabber.org/protocol/pubsub#publish-options">>],
                              options = [],sub_els = []},
                          #xdata_field{
                              label = <<>>,type = undefined,
                              var = <<"secret">>,required = false,desc = <<>>,
                              values = [<<"zzgFfPiLCi8n99zfuUC0xkFK">>],
                              options = [],sub_els = []}]},
             subscribe = undefined,unsubscribe = undefined,
             options = undefined,items = undefined,retract = undefined,
             create = undefined,configure = undefined,default = undefined,
             delete = undefined,purge = undefined,rsm = undefined}],
    meta = #{}}
2021-07-28 14:01:10.899144+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook store_mam_message: mod_mam:store_mam_message/7
2021-07-28 14:01:10.899383+00:00 [notice] <0.982.0> (tcp|<0.982.0>) Send XML on stream = <<"<iq to='p2.dong.tld' from='db' type='set' id='rr-1627480902897-12131238736936548073-IcZtR92rQos+mpZzPMsXFcBd2sI=-126253382'><pubsub xmlns='http://jabber.org/protocol/pubsub'><publish node='6bwEllwfFHhP'><item><notification xmlns='urn:xmpp:push:0'/></item></publish><publish-options><x type='submit' xmlns='jabber:x:data'><field var='FORM_TYPE'><value>http://jabber.org/protocol/pubsub#publish-options</value></field><field var='secret'><value>zzgFfPiLCi8n99zfuUC0xkFK</value></field></x></publish-options></pubsub></iq>">>
2021-07-28 14:01:10.914379+00:00 [debug] <0.987.0>@ejabberd_shaper:update/2:75 Shaper update:
#state{maxrate = 1000,burst_size = 1000,acquired_credit = 1000,
       lasttime = 1627480870861579} =>
{#state{maxrate = 1000,burst_size = 1000,acquired_credit = 1000,
        lasttime = 1627480870914283},
 0}
2021-07-28 14:01:10.914499+00:00 [notice] <0.989.0> (websocket|<0.988.0>) Received XML on stream = <<"<a xmlns='urn:xmpp:sm:3' h='19'/>">>
2021-07-28 14:01:10.914728+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_handle_recv: mod_stream_mgmt:c2s_handle_recv/3
2021-07-28 14:01:10.915080+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_authenticated_packet: mod_client_state:c2s_authenticated_packet/2
2021-07-28 14:01:10.915164+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook offline_message_hook: mod_offline:store_packet/1
2021-07-28 14:01:10.915230+00:00 [debug] <0.989.0>@ejabberd_hooks:safe_apply/4:231 Running hook c2s_authenticated_packet: mod_stream_mgmt:c2s_authenticated_packet/2
2021-07-28 14:01:10.915638+00:00 [debug] <0.989.0>@mod_stream_mgmt:check_h_attribute/2:480 customer-2901@db/converse.js-135378902 acknowledged 19 of 19 stanzas
2021-07-28 14:01:10.927192+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook offline_message_hook: mod_push:offline_message/1
2021-07-28 14:01:10.927448+00:00 [debug] <0.912.0>@ejabberd_hooks:safe_apply/4:231 Running hook offline_message_hook: ejabberd_sm:bounce_offline_message/1
2021-07-28 14:01:10.931075+00:00 [notice] <0.982.0> (tcp|<0.982.0>) Received XML on stream = <<"<iq from=\"p2.dong.tld\" id=\"rr-1627480902897-12131238736936548073-IcZtR92rQos+mpZzPMsXFcBd2sI=-126253382\" to=\"db\" type=\"result\"></iq>">>
2021-07-28 14:01:10.931641+00:00 [debug] <0.982.0>@ejabberd_router:do_route/1:384 Route:
#iq{id = <<"rr-1627480902897-12131238736936548073-IcZtR92rQos+mpZzPMsXFcBd2sI=-126253382">>,
    type = result,lang = <<>>,
    from = #jid{user = <<>>,server = <<"p2.dong.tld">>,resource = <<>>,
                luser = <<>>,lserver = <<"p2.dong.tld">>,lresource = <<>>},
    to = #jid{user = <<>>,server = <<"db">>,resource = <<>>,luser = <<>>,
              lserver = <<"db">>,lresource = <<>>},
    sub_els = [],
    meta = #{ip => {0,0,0,0,0,65535,2570,1}}}
2021-07-28 14:01:10.932159+00:00 [debug] <0.498.0>@mod_push:notify/5:509 p2.dong.tld accepted notification for driver-9448@db (6bwEllwfFHhP)

Bug description

I've used push-server external service for the push-proxy purposes. And on the client side I have enabled push-notifications with the stanza:

<iq type="set" id="x43" xmlns="jabber:client">
    <enable xmlns="urn:xmpp:push:0" jid="p2.dong.tld" node="6bwEllwfFHhP">
        <x xmlns="jabber:x:data" type="submit">
            <field var="FORM_TYPE">
                <value>http://jabber.org/protocol/pubsub#publish-options</value>
            </field>
            <field var="secret">
                <value>zzgFfPiLCi8n99zfuUC0xkFK</value>
            </field>
        </x>
    </enable>
</iq>

Push-notifications have been enabled properly. And next by the next step my app server receives the next stanza:
For chat One-One it's fine

<iq from="db" id="rr-1627480115912-12343113350938073144-3kove8nEAG/tu6hlf5P0ToTPKqE=-126253382" to="p2.dong.tld" type="set">
    <pubsub xmlns="http://jabber.org/protocol/pubsub">
        <publish node="6bwEllwfFHhP">
            <item>
                <notification xmlns="urn:xmpp:push:0">
                    <x xmlns="jabber:x:data" type="submit">
                        <field type="hidden" var="FORM_TYPE">
                            <value>urn:xmpp:push:summary</value>
                        </field>
                        <field label="The body text of the last received message" type="text-single" var="last-message-body">
                            <value>s</value>
                        </field>
                    </x>
                </notification>
            </item>
        </publish>
        <publish-options>
            <x xmlns="jabber:x:data" type="submit">
                <field var="FORM_TYPE">
                    <value>http://jabber.org/protocol/pubsub#publish-options</value>
                </field>
                <field var="secret">
                    <value>zzgFfPiLCi8n99zfuUC0xkFK</value>
                </field>
            </x>
        </publish-options>
    </pubsub>
</iq>

for group chat, the notification does not include message body or sender

<iq from="db" id="rr-1627478971565-7344095491115974380-SL4nIYtUE8Qs8NT+0QCT67lqxws=-126253382" to="p2.dong.tld" type="set">
    <pubsub xmlns="http://jabber.org/protocol/pubsub">
        <publish node="6bwEllwfFHhP">
            <item>
                <notification xmlns="urn:xmpp:push:0"></notification>
            </item>
        </publish>
        <publish-options>
            <x xmlns="jabber:x:data" type="submit">
                <field var="FORM_TYPE">
                    <value>http://jabber.org/protocol/pubsub#publish-options</value>
                </field>
                <field var="secret">
                    <value>zzgFfPiLCi8n99zfuUC0xkFK</value>
                </field>
            </x>
        </publish-options>
    </pubsub>
</iq>
@licaon-kter
Copy link
Contributor

Sidetrack question, why would you give to Apple and Google the contents of your messages in cleartext?

@dongnguyen7
Copy link
Author

@licaon-kter for me, it's helpful the user can see the message on the lock screen no need to open the app.

@weiss weiss closed this as completed in 103e98b Jul 28, 2021
@licaon-kter
Copy link
Contributor

@dongnguyen7 yes, indeed but that's a privacy leak, did you inform your users that messages will be sent in clear to Google, Apple and you (the app developer)?

Eg. Other apps use other mechanisms to get the message when the user opens the app or in the next network access window of time. Like Monal or Siskin or Conversations do.

Your app handles encrypted messages too? Eg. OMEMO or PGP

@badlop badlop added this to the ejabberd 21.xx milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ejabberd 21.12
Development

No branches or pull requests
3 participants
@badlop @licaon-kter @dongnguyen7