Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ejabberd to not use Distillery #3788

Closed
2 of 4 tasks
badlop opened this issue Mar 8, 2022 · 0 comments
Closed
2 of 4 tasks

Update ejabberd to not use Distillery #3788

badlop opened this issue Mar 8, 2022 · 0 comments
Labels
Component:Elixir Packaging:Docker Docker image from Docker Hub

Comments

@badlop
Copy link
Member

badlop commented Mar 8, 2022

Support to build OTP relases using Elixir was first added to ejabberd in commit 4ae7c81 for 15.09 using the libraries exrm and relx:

exrm, or Elixir Release Manager, provides mix tasks for building, upgrading, and controlling release packages for your application.

relx is a library that assembles Erlang/OTP releases. Given a release specification and a list of directories in which to search for OTP applications it will generate a release output. It is generally used through the Erlang/OTP build tool rebar3 which provides a cli interface.

Those libraries were replaced with Distillery to ejabberd in commit 1c8edd0 for release 16.12, and in docker-ejabberd in commit 9d97b7d for 19.08:

Distillery: Build releases of your Mix projects with ease!

But nowadays, Elixir doesn't need Distillery to build OTP releases... Release support, with a different implementation, was included in Elixir v1.9, check the Mix Release documentation.

Tasks:

  • Don't include Distillery dependency in ejabberd: done in a846260
  • Don't use Distillery in docker-ejabberd: done in processone/docker-ejabberd@2ae9f00
  • Don't use Distillery in ProcessOne binary installers. Check new installers work correctly
  • Inform about this in the next release notes, in case some packager still used Distillery
@badlop badlop added Component:Elixir Packaging:Docker Docker image from Docker Hub labels Mar 8, 2022
@badlop badlop changed the title Update ejabberd and docker-ejabberd to not require Distillery Update ejabberd to not use Distillery Mar 8, 2022
badlop added a commit to badlop/ejabberd that referenced this issue Mar 8, 2022
badlop added a commit to badlop/ejabberd that referenced this issue Mar 9, 2022
@badlop badlop added this to the ejabberd 22.xx milestone Apr 11, 2022
@badlop badlop closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Elixir Packaging:Docker Docker image from Docker Hub
Projects
None yet
Development

No branches or pull requests

1 participant