Fix issue #1078: ejabberd_c2s process didn't clear session data in some case #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that, `send_element/2` will call `exit/1` if the connection is closed, So, if create session data before response bind-iq-result, the ejabberd_c2s process may jump into `terminate/3` without update state data. As a result, it wouldn't delete the session data.
|
This has been fixed in a different way. Thanks for your contribution anyway! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that,
send_element/2will callexit/1if the connection is closed,So, if create session data before response bind-iq-result,
the ejabberd_c2s process may jump into
terminate/3without update state data.As a result, it wouldn't delete the session data.
More details, see #1078
In short, we should call
send_element/2beforeejabberd_sm:open_session.