Return error when blocking last activity request

[weiss]

Return a generic service-unavailable error whenever an IQ-get or IQ-set is rejected (as per RFC 6121, XEP-0016, and XEP-0191).

[coveralls]

Coverage increased (+0.002%) to 31.407% when pulling f58c2ed on weiss:avoid-presence-leak into 65ad70d on processone:master.

[zinid]

I'm not sure how to debug those service-unavailable received. We got a lot of questions like: "hey, I got service-unavailable, wtf?"

[weiss]

Fair enough. I've updated the PR so that it only adds a service-unavailable error for blocked last activity request (instead of dropping them silently) and leaves the other error messages alone. The new error is again without an error text, as there's currently no text when blocking other IQ/message stanzas either. Could add that if you like.

[zinid]

We also probably can make sure any service-unavailable have error text except the ones related to privacy and presence. Presences will not be leaked in that case I think.

[coveralls]

Coverage increased (+0.001%) to 31.409% when pulling 36164d9 on weiss:avoid-presence-leak into ef90a38 on processone:master.

[weiss]

We also probably can make sure any service-unavailable have error text except the ones related to privacy and presence. Presences will not be leaked in that case I think.

Yes. I think it already works that way, with the exception of groupchat messages (those aren't easy to fix) and IQ stanzas. In my original commit I tried to avoid the leak for IQ stanzas by removing an error text from ejabberd_sm, but we could instead wrap that one into a privacy list check and only include the error text if the traffic isn't blocked.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.