Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Component Connection Hooks #1201

Merged
merged 3 commits into from
Jul 21, 2016
Merged

Conversation

xmppjingle
Copy link

@xmppjingle xmppjingle commented Jul 18, 2016

External Component Connection Hooks

Event List:
component_connected(ComponentAddress) -> ok
component_disconnected(ComponentAddress, Reason) -> ok

@zinid
Copy link
Contributor

zinid commented Jul 18, 2016

Isn't it better to call component_disconnect hook in terminate/3 when StateName is session_established (along with de-registering route)? Because in your version if an ejabberd_service process fails the hook won't be called.

@zinid zinid self-assigned this Jul 18, 2016
@xmppjingle
Copy link
Author

Thanks for the suggestion. I will make the modifications and push again.

Changed Hook Trigger Event and included a Reason upon
component_disconnected/2 Hook
@xmppjingle
Copy link
Author

Suggestion applied and Reason added upon disconnection

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 32.332% when pulling 6983dfa on xmppjingle:master into 8bc3dc9 on processone:master.

@zinid zinid merged commit dd38bef into processone:master Jul 21, 2016
@mremond
Copy link
Member

mremond commented Jul 21, 2016

Thanks !

@mremond mremond added this to the ejabberd 16.08 milestone Jul 21, 2016
@lock
Copy link

lock bot commented Jun 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants