Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to disable prepared statements for postgresql #1317

Merged
merged 1 commit into from Nov 26, 2019

Conversation

sabudaye
Copy link
Contributor

@sabudaye sabudaye commented Oct 3, 2016

@weiss
Copy link
Member

weiss commented Oct 4, 2016

I didn't look into the actual change, just some random comments:

  • According to Travis, the build currently fails with src/ejabberd_sql.erl:526: variable 'Host' is unbound.
  • The ejabberd.yml.example diff contains many lines where only whitespace is changed.
  • I'd rather name the option sql_prepared_statements and document that it currently only affects PostgreSQL.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 31.833% when pulling 026394a on sabudaye:pg_prepared_statements into 9cee376 on processone:master.

@sabudaye
Copy link
Contributor Author

sabudaye commented Oct 5, 2016

@weiss fixed. Not sure about ?MYNAME macros, but it was already used in ejabberd_auth_* modules in similar case

@p1bot
Copy link
Collaborator

p1bot commented Jan 21, 2019

Hi @sabudaye, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added cla-missing Contributor needs to sign Contribution License Agreement and removed Component:Databases labels Jan 21, 2019
@p1bot
Copy link
Collaborator

p1bot commented Jan 21, 2019

You did it @sabudaye!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

@p1bot p1bot removed the cla-missing Contributor needs to sign Contribution License Agreement label Jan 21, 2019
@alexeyshch alexeyshch merged commit 026394a into processone:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants