Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rebar3 in Travis tests #3577

Closed
wants to merge 1 commit into from
Closed

Conversation

badlop
Copy link
Member

@badlop badlop commented Apr 16, 2021

ejabberd can be compiled using rebar2, rebar3 or mix. I have been using rebar3 since some months ago, and it works perfectly for building ejabberd, at least in my experience.

Regarding Travis, I haven't seen any specific performance benefit in Travis using rebar3 instead of rebar2: the testing time just reduces between one to three minutes (15 -> 14 minutes, 18 -> 15 minutes)

But by upgrading Travis from rebar2 to rebar3, we move ejabberd one step forward, and leave rebar2 one step behind. This would make easier, in the future, to drop rebar2 support.

So, here is a proposal to use rebar3 in Travis. Any feedback and opinion is welcome.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 34.294% when pulling 49c757f on badlop:travis-rebar3 into e462f0a on processone:master.

@badlop badlop closed this May 25, 2021
@badlop badlop deleted the travis-rebar3 branch May 25, 2021 16:53
@badlop
Copy link
Member Author

badlop commented May 25, 2021

Now that ejabberd won't use Travis CI, this PR is useless. BTW, the new github actions workflow includes tests for rebar2 and rebar3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants