Fixed srg_create params and shared roster groups cache issues

[sarsonj]

This pull request fixes issues with shared roster groups:

1. fixed srg_create administrative api function - it accepted old name parameter and stores it as name into OPTS. The parameter should be now named and stored as label
2. it fixes cache issues. The cache was cleaned before item was added / removed from shared roster group. So that it can happen (and it happened to us), that user was added to shared roster group, but cache item was reloaded before item was updated in database - so there were old data in cache. I changed the order (first update in DB, then delete cache) and it fixed this inconsistency issue.

This pull request is fixing issue #3576.

[p1bot]

Hi @sarsonj, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

[coveralls]

Coverage remained the same at 34.984% when pulling dcc5d87 on tappytaps:srg-cache-fix into e462f0a on processone:master.

[p1bot]

You did it @sarsonj!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

[badlop]

Thanks!

I was finally able to get the testing evironment, and I've checked this:

1. installed ejabberd 20.03
2. created mysql & pgsql databases
3. created several shared roster groups
4. upgraded ejabberd to 21.04

Then i confirm:

• A) opts->name are accepted correctly, no need to update the database
• B) srg_create API uses the old "name" argument, which is confusing
• C) newly created groups work correctly, but name is only displayed after a server restart

After applying your PR, B) and C) get fixed :)

[Neustradamus]

Thanks @badlop for the test and merging.

Thanks a lot to @sarson for your PR :)

[badlop]

Thanks @badlop for the test and merging.

Thanks a lot to @sarson for your PR :)

That is a useless comment, it adds nothing. It's annoying. You did nothing at all. You just added several useless comments.

Please, can you remove that comment immediately?

And please, can you NOT add more useless comments?

Thanks!