move spool dir to make it fully configurable per ejabberdctl.cfg #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the packaged rpm the spool dir is set to:
```
: "${SPOOL_DIR:="/opt/ejabberd/database/$ERLANG_NODE"}"
```
However, `$ERLANG_NODE` is effectively set later (now in line 67), which effectively makes spool dir always in `...../ejabberd@localhost`
|
Hi @duritong, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
p1bot
added
the
cla-missing
|
You did it @duritong! Thank you for signing the ProcessOne Contribution License Agreement. We will have a look at your contribution! |
p1bot
removed
the
cla-missing
|
Good catch, thanks. Yes this should be fixed, I'm just a little unsure whether it might make sense to move |
badlop
added a commit
to badlop/ejabberd
that referenced
this pull request
Feb 9, 2024
move spool dir to make it fully configurable per ejabberdctl.cfg (processone#3863)
badlop
added a commit
to badlop/ejabberd
that referenced
this pull request
Feb 9, 2024
move spool dir to make it fully configurable per ejabberdctl.cfg (processone#3863)
badlop
added a commit
that referenced
this pull request
Feb 9, 2024
move spool dir to make it fully configurable per ejabberdctl.cfg (#3863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the packaged rpm the spool dir is set to:
However,
$ERLANG_NODEis effectively set later (now in line 67), which effectively makes spool dir always in...../ejabberd@localhost