Improve get_roster command result: show groups as a list #4088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
get_roster
command, and fixes ejabberdctl to fully support that command and other ones like that.This changes the API, so the release notes should describe it. For example:
Changes in
get_roster
commandThere are some changes in the result output of the
get_roster
command defined inmod_admin_extra
:ask
is renamed topending
group
is renamed togroups
groups
is a list with all the group namesFor example, let's say that
admin@localhost
has two contacts: a contact is present in two groups (group1
andgroup2
), the other contact is only present in a group (group3
).The old get_roster command in ejabberd 23.04 and previous versions was like:
The new get_roster command in ejabberd 23.XX and newer versions returns as result:
Notice that the
ejabberdctl
command-line tool since now will represent list elements in results separated with;