Merge pull request #63 from 0x42/fix_setup_dh_double_free

Fix double free in setup_dh()
processone · Jan 18, 2024 · 4961c06 · 4961c06
2 parents ae5f748 + da16622
commit 4961c06
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/c_src/fast_tls.c b/c_src/fast_tls.c
@@ -415,6 +415,7 @@ static int setup_dh(SSL_CTX *ctx, const unsigned char *dh_der, size_t dh_size, c
         if (EVP_PKEY_fromdata_init(pctx) <= 0 ||
             EVP_PKEY_fromdata(pctx, &pkey, EVP_PKEY_KEY_PARAMETERS, params) <= 0) {
             EVP_PKEY_CTX_free(pctx);
+            return 0;
         }
         if (SSL_CTX_set0_tmp_dh_pkey(ctx, pkey) != 1) {
             EVP_PKEY_free(pkey);