Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS with openssl 1.1.0 #6

Closed
debalance opened this issue Jun 26, 2016 · 5 comments
Closed

FTBFS with openssl 1.1.0 #6

debalance opened this issue Jun 26, 2016 · 5 comments

Comments

@debalance
Copy link

Hi,

fast_tls fails to build with with OpenSSL 1.1.0 which is about to be released.

You can find more information here: https://bugs.debian.org/828297

prefiks added a commit that referenced this issue Jun 27, 2016
@prefiks
Copy link
Member

prefiks commented Jun 27, 2016

This should be fixed by commit 3d09f86

@prefiks prefiks closed this as completed Jun 27, 2016
@debalance
Copy link
Author

debalance commented Jun 27, 2016

Thx for fixing it so quickly! This solves the FTBFS issue for me, but rebar eunit segfaults:

root@emmagan:/tmp/buildd/erlang-p1-tls-1.0.4# rebar eunit
==> erlang-p1-tls-1.0.4 (eunit)
All 8 tests passed.
Cover analysis: /build/erlang-p1-tls-1.0.4/.eunit/index.html
Coverdata export: /build/erlang-p1-tls-1.0.4/.eunit/cover.coverdata
Segmentation fault

However that probably happens because erlang itself or some other library hasn't been rebuilt with the new libssl yet. With libssl1.0.2 I don't have that problem.

@prefiks
Copy link
Member

prefiks commented Jun 27, 2016

Ok, i see that SIGSEGV too with 1.1.0, will see if i will be able to see what causes that.

@prefiks
Copy link
Member

prefiks commented Jun 27, 2016

This segfault should be fixed in latest version, looks like openssl do now call cleanup function when library is unregistered, and this tried to call callbacks from p1_tls_drv.so but those were no longer available at that point, i made it call cleanup code earlier, so we no longer try to do that.

@debalance
Copy link
Author

I can confirm the segfault is gone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants