Add p1_proxy_protocol module #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The p1_proxy_protocol module decodes HAproxy protocol (v1 and v2) headers.
|
Looks ok, maybe just we could define -spec for decode (gen_tcp | ssl, inet:socket(), integer()) -> {error, atom()} | {{inet:ip_address(), inet:port_number()}, {inet:ip_address(), inet:port_number()}} | {undefined, undefined} |
Add a function specification for p1_proxy_protocol:decode/3 (thanks to Paweł Chmielowski) and adjust the file header comments and license text (thanks to Marcus Rückert).
weiss
force-pushed
the
proxy-protocol
branch
from
1373c25
to
4d6d213
Compare
|
I pushed another commit which adds the function spec and also changes the license text from GPL to Apache 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the
p1_proxy_protocolmodule (which decodes HAproxy protocol (v1 and v2) headers) from ejabberd to make it reusable by other applications (I'd like to use it in stun). Once it's included withp1_utils, ejabberd could be updated to use it from there.