chore(POINT-941): Add bancontact to JS #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@processout/frontend-developers Can I have a review here, please? |
roshan-gorasia-cko
requested review from
wojciech-niedbala-cko,
adam-blevins-cko and
zhengyi-li-cko
Done: 2b05132, Thanks! |
wojciech-niedbala-cko
approved these changes
May 9, 2023
adam-blevins-cko
approved these changes
May 9, 2023
There was a problem hiding this comment.
LGTM!
The attached ticket talked about updating this switch statement for card number lengths based on scheme. There is no carte bancaire case, nor any new one for the bancontact case.
Do we know if that's what we want? Are the defaults for min/max length of the card number good enough here (min 12, max 19)?
We will raise a separate PR for that. We are still investigating. Thanks. |
|
I guess the pin is same as normal card, 3 digits, right? |
zhengyi-li-cko
approved these changes
May 9, 2023
|
I have attached a test |
|
|
||
| "carte bancaire": ["49707", "49783", "49771", "45950", "45334", "51336", "49836", "47722", "45721", "54515", "49732", "51345", "45626", "49774", "49734", "49738", "40220", "53253", "56125", "49835", "49715", "58171", "45619", "45954", "49793", "43782", "41506", "49773", "53710", "51338", "53102", "45940", "45627", "49766", "46978", "49720", "45611", "49902", "55700", "49796", "49733", "45930", "55961", "49792", "51348", "52945", "49708", "49726", "45610", "44995", "49739", "41507", "47717", "54985", "58170", "51327", "47260", "45335", "43951", "51365", "43950", "49746", "40100", "45629", "49731", "51810", "45332", "42011", "55420", "42346", "41993", "45333", "49723", "51361", "49719", "45929", "55426", "44244", "51330", "55981", "49752", "45621", "49764", "49755", "51321", "45615", "49765", "51375", "47802", "51372", "49742", "51377", "55886", "49837", "51623", "46983", "49716", "55391", "67759", "45613", "45568", "49758", "46609", "47480", "44841", "45958", "51320", "47729", "51319", "49722", "51317", "49745", "67117", "49797", "51313", "49714", "49704", "47726", "44996", "42012", "49791", "49749", "51341", "41503", "51325", "55980", "46657", "49711", "52948", "51371", "49717", "49838", "51314", "46703", "40355", "51324", "51350", "55892", "53103", "51353", "43783", "55496", "49839", "45612", "45620", "46547", "51316", "49763", "49721", "51379", "49728", "49770", "49776", "51521", "49909", "45616", "52954", "51312", "49901", "45939", "49712", "49775", "45720", "52166", "49735", "46982", "51337", "46361", "51374", "49788", "47961", "49785", "49741", "51385", "46986", "51364", "49795", "51992", "49703", "45937", "51323", "52931", "45617", "49760", "53119", "49709", "49724", "45566", "45623", "52922", "46969", "53506", "51360", "47427", "45560", "40593", "45628", "51357", "41505", "51315", "45337", "52942", "53610", "53611", "40594", "45624", "48651", "51366", "45567", "46896", "40657", "51750", "52933", "49756", "52943", "49790", "54953", "49761", "45056", "48373", "49906", "47809", "54284", "48369", "51332", "55399", "44855", "40223", "49777", "43787", "58175", "41509", "45614", "48160", "51301", "49754", "49753", "45054", "46980", "49737", "52920", "51356", "49713", "49706", "49725", "51390", "49779", "51370", "51318", "47268", "51354", "49750", "51386", "40221", "51367", "49744", "49730", "51373", "45771", "51736", "45745", "53411", "52371", "51300", "43953", "47718", "49748", "58177", "53711", "58176", "52886", "48362", "45330", "44245", "49740", "45622", "46625", "41717", "51302", "44997", "52944", "51369", "49747", "49772", "58178", "49768", "52941", "51363", "51362", "49781", "45618", "53234", "49789", "51326", "49799", "40209", "45331", "49702", "58173", "58174", "49743", "51352", "51311", "45625", "51335", "49905", "49786", "41628", "49798", "58179", "53801", "49767", "45339", "49769", "53250", "51328", "49782", "53410", "58172", "49778", "45051", "49736", "49718", "49900", "49903", "49784", "55397", "46321", "51376", "51331", "49710", "56124", "44853", "49759", "51351", "52949", "53532", "49904", "49787", "51322", "49762", "55888", "51620", "49794", "51355", "45932", "52946", "49780", "49757", "49729", "52947", "51310", "51329", "53502", "49751", "53255", "51378", "51303", "49727", "45933"] | ||
| "carte bancaire": ["49707", "49783", "49771", "45950", "45334", "51336", "49836", "47722", "45721", "54515", "49732", "51345", "45626", "49774", "49734", "49738", "40220", "53253", "56125", "49835", "49715", "58171", "45619", "45954", "49793", "43782", "41506", "49773", "53710", "51338", "53102", "45940", "45627", "49766", "46978", "49720", "45611", "49902", "55700", "49796", "49733", "45930", "55961", "49792", "51348", "52945", "49708", "49726", "45610", "44995", "49739", "41507", "47717", "54985", "58170", "51327", "47260", "45335", "43951", "51365", "43950", "49746", "40100", "45629", "49731", "51810", "45332", "42011", "55420", "42346", "41993", "45333", "49723", "51361", "49719", "45929", "55426", "44244", "51330", "55981", "49752", "45621", "49764", "49755", "51321", "45615", "49765", "51375", "47802", "51372", "49742", "51377", "55886", "49837", "51623", "46983", "49716", "55391", "67759", "45613", "45568", "49758", "46609", "47480", "44841", "45958", "51320", "47729", "51319", "49722", "51317", "49745", "67117", "49797", "51313", "49714", "49704", "47726", "44996", "42012", "49791", "49749", "51341", "41503", "51325", "55980", "46657", "49711", "52948", "51371", "49717", "49838", "51314", "46703", "40355", "51324", "51350", "55892", "53103", "51353", "43783", "55496", "49839", "45612", "45620", "46547", "51316", "49763", "49721", "51379", "49728", "49770", "49776", "51521", "49909", "45616", "52954", "51312", "49901", "45939", "49712", "49775", "45720", "52166", "49735", "46982", "51337", "46361", "51374", "49788", "47961", "49785", "49741", "51385", "46986", "51364", "49795", "51992", "49703", "45937", "51323", "52931", "45617", "49760", "53119", "49709", "49724", "45566", "45623", "52922", "46969", "53506", "51360", "47427", "45560", "40593", "45628", "51357", "41505", "51315", "45337", "52942", "53610", "53611", "40594", "45624", "48651", "51366", "45567", "46896", "40657", "51750", "52933", "49756", "52943", "49790", "54953", "49761", "45056", "48373", "49906", "47809", "54284", "48369", "51332", "55399", "44855", "40223", "49777", "43787", "58175", "41509", "45614", "48160", "51301", "49754", "49753", "45054", "46980", "49737", "52920", "51356", "49713", "49706", "49725", "51390", "49779", "51370", "51318", "47268", "51354", "49750", "51386", "40221", "51367", "49744", "49730", "51373", "45771", "51736", "45745", "53411", "52371", "51300", "43953", "47718", "49748", "58177", "53711", "58176", "52886", "48362", "45330", "44245", "49740", "45622", "46625", "41717", "51302", "44997", "52944", "51369", "49747", "49772", "58178", "49768", "52941", "51363", "51362", "49781", "45618", "53234", "49789", "51326", "49799", "40209", "45331", "49702", "58173", "58174", "49743", "51352", "51311", "45625", "51335", "49905", "49786", "41628", "49798", "58179", "53801", "49767", "45339", "49769", "53250", "51328", "49782", "53410", "58172", "49778", "45051", "49736", "49718", "49900", "49903", "49784", "55397", "46321", "51376", "51331", "49710", "56124", "44853", "49759", "51351", "52949", "53532", "49904", "49787", "51322", "49762", "55888", "51620", "49794", "51355", "45932", "52946", "49780", "49757", "49729", "52947", "51310", "51329", "53502", "49751", "53255", "51378", "51303", "49727", "45933"], | ||
| "bancontact": ["6703", "487104", "670305", "670330", "670319", "670300", "670342", "487109", "670397", "670375", "670310"] |
There was a problem hiding this comment.
Adding 6703 and 670305 (and all the others) is redundant. As shared enclosed with a Bancontact BIN range analysis, we may be able to clean the code by just having the Maestro range (6703) and Visa (487104)
bancontact.csv
There was a problem hiding this comment.
I opened the PR for this #89. Thanks for the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to add bancontact to our JS so it's shown in the front-end. The issue we’re trying to solve is that currently, the merchant is unaware a card is Bancontact - therefore if a customer wrongly selects this, it could lead to failures.
Solution
Add these values for bancontact:
Jira Issue
https://checkout.atlassian.net/browse/POINT-941