Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages > Add New > Bookmarks (wrong separator position) #595

Closed
fijha opened this issue May 13, 2018 · 2 comments
Closed

Pages > Add New > Bookmarks (wrong separator position) #595

fijha opened this issue May 13, 2018 · 2 comments
Labels
resolution: fixed-please close

Comments

@fijha
Copy link

fijha commented May 13, 2018

Expected behavior

Bookmarks separator should be on top of the "Bookmarks" item.

Actual behavior

Separator is on the bottom.

Suggestion for a possible fix

Remove highlight from:

wire/modules/Process/ProcessPageEdit/PageBookmarks.php (line 101)

$add->set($classKey, 'highlight separator');
ryancramerdesign added a commit to processwire/processwire that referenced this issue May 21, 2018
@ryancramerdesign
Fix issue processwire/processwire-issues#595 where horizontal separat…
2ba8d29 
…or in dropdown nav wasn't quite right for the Page Add > Bookmarks option
@ryancramerdesign
Copy link
Member

Thanks, I've pushed your suggested fix for this issue.

@netcarver
Copy link
Collaborator

@fijha Hello. I see that Ryan pushed a fix for this issue. If that resolved things to your satisfaction, please could you close this issue.

@fijha fijha closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution: fixed-please close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@netcarver @ryancramerdesign @fijha