Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling repeater item open/closed hides outline in AdminThemeUikit #603

Closed
Toutouwai opened this issue May 21, 2018 · 1 comment
Closed

Toggling repeater item open/closed hides outline in AdminThemeUikit #603

Toutouwai opened this issue May 21, 2018 · 1 comment
Labels
resolution: fixed-please close

Comments

@Toutouwai
Copy link

Short description of the issue

When a repeater item is toggled open and closed the outline of the repeater item becomes hidden in AdminThemeUikit. Seems to be due to the overflow: hidden inline style that is applied after the item is toggled.

repeater-outline

Setup/Environment

  • ProcessWire version: 3.0.103
ryancramerdesign added a commit to processwire/processwire that referenced this issue May 23, 2018
@ryancramerdesign
Fix issue processwire/processwire-issues#603 where toggling repeater …
d06fd64 
…item open/closed makes outline disappear the second time you do it
@ryancramerdesign
Copy link
Member

ryancramerdesign commented May 23, 2018 •
edited

Thanks, I've pushed a fix for this issue. Thanks for pointing me to the overflow. I don't know where that overflow:hidden is coming from, but seems to be something in jQuery or jQuery UI as far as I can tell. It's not admin theme specific. I've updated the open/close event to remove that inline css, which seems to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution: fixed-please close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryancramerdesign @Toutouwai