InputfieldCKEditor 'extraAllowedContent': empty module config setting prevents use of config.js

[Toutouwai]

Short description of the issue

When the InputfieldCKEditor module config field for "Extra Allowed Content" is empty, the module includes this as an empty string in the inline Javascript configuration for the field.

This prevents or overrides any extraAllowedContent option that might be defined for the field in config.js

CKEDITOR.editorConfig = function( config ) {
    // Define changes to default configuration here. For example:
    config.extraAllowedContent = 'p(tip)';
};

Suggestion for a possible fix

Somewhere in InputfieldCKEditor::renderReady before the $settings array is passed to $config->js...

if(empty($settings['extraAllowedContent'])) unset($settings['extraAllowedContent']);

Setup/Environment

• ProcessWire version: 3.0.106

[Toutouwai]

Just thinking... if there is something defined for "Extra Allowed Config" in the module config then this will also prevent the use of extraAllowedContent in config.js.

Really, the settings in the inline JS and the linked config.js file should be merged, but I guess this could be seen as a CKEditor issue rather than a PW issue.

[ryancramerdesign]

Thanks, I've pushed your suggested fix for the issue. As to whether they should be merged, I think it just depends on what one's intention is, as the intention might be to completely override, which is what it does now. Though if it ever surfaces as a recurring problem for people we can look into more options.

[Toutouwai]

Thanks.