Bug Fix: InputfieldPageAutocomplete.js can't trigger a requiredIf #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e its value starts with a comma.
ryancramerdesign
added a commit
that referenced
this pull request
Jan 4, 2024
…ssues#1855 in InputfieldPageAutocomplete.js Co-authored-by: hiboudev <hiboudev@gmail.com>
|
Thanks @hiboudev I've added your PR. Keep an eye out for issues just in case, as I recall there at least used to be a reason for the leading comma. But am not sure if it is still the case, or if I'm maybe confusing with another module, as I couldn't find anything in InputfieldPageAutocomplete that was relying upon a leading comma yet. |
|
@ryancramerdesign Thanks. I'm using this fix since months and didn't see any issue so far. |
ryancramerdesign
added
the
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In InputfieldPageAutocomplete.js, value always start with a comma, so inputfields.js->inputfieldChange() doesn't parse it correctly. So other fields that depends on it by a requiredIf are never updated.