-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add structlog config #1031
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
So you were mentioning in the issue that it wasn't working as intended ? Were you able to fix that ?
I wonder if we should, somehow, test that. Maybe install this in a procrastinate_demo project ? Do you have an opinion ? (I'm not saying you have to do this on the PR (but you may), just asking. Your PR may should get merged at some point, even without that)
docs/howto/production/logging.md
Outdated
|
||
A minimal configuration would look like: | ||
|
||
```py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I think we're using python
elsewhere, rather than py
)
Hm, I've tried your code and it hasn't worked on the demo so far. I'll try to share a complete traceback later, but has it been working for you ? |
Yes, it has on a bigger project. Did you try the minimal config or the one from the structlog docs? |
I tried the one from your PR, and tried to put it as-is in the sync demo. |
Closes #1030
Successful PR Checklist:
PR label(s):