Use typing_extensions only if Python < 3.8 #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures don't seem to be related to the changes. |
|
Yes, the same error suddenly appeared in an unrelated PR: #655 I'll fix it on a different PR, don't mind that :) |
|
BTW, glad to see you've made it to your first public PR ! Congratulations :) And it's nice too ! |
ewjoachim
force-pushed
the
typing_extensions
branch
from
c40f3f3
to
381703c
Compare
|
Ok, I've fixed the problem (it was actually due to the update of deps in this PR, but it was due to some of the deps that got upgraded along the way, so nothing bad on your side). I've rebased your PR and reran We should be able to merge as soon as CI passes. |
ewjoachim
approved these changes
Jul 21, 2022
Coverage reportThe coverage rate went from
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #644
Successful PR Checklist: