Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib_resources.files instead of .read_text() #724

Merged
merged 1 commit into from Jan 10, 2023
Merged

Use importlib_resources.files instead of .read_text() #724

merged 1 commit into from Jan 10, 2023

Conversation

ewjoachim
Copy link
Member

Closes #719

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

@ewjoachim
Use importlib_resources.files instead of .read_text()
a1e4812 
requires importlib_resources >= 1.4
@ewjoachim ewjoachim requested a review from a team as a code owner January 10, 2023 21:22
@ewjoachim ewjoachim merged commit 2e6ade8 into main Jan 10, 2023
@ewjoachim ewjoachim deleted the importlib-resources-files branch January 10, 2023 21:24
@github-actions
Copy link

Coverage report

The coverage rate went from 95% to 95% ⬆️
The branch rate is 82%.

100% of new lines are covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: read_text is deprecated.
1 participant
@ewjoachim