Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions CI #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Github actions CI #29

wants to merge 1 commit into from

Conversation

pedrofurtado
Copy link

@pedrofurtado pedrofurtado commented Aug 4, 2021

@prodis 👍

the output of CI can be checked here (until PR merged): https://github.com/pedrofurtado/correios-cep/actions/runs/1095889282

@prodis
Copy link
Owner

prodis commented Aug 4, 2021

@pedrofurtado Thank you for your PR. But what is the motivation to move the CI from Travis to GitHub Actions?

@pedrofurtado
Copy link
Author

pedrofurtado commented Aug 4, 2021

Hi, @prodis ! The motivation and suggestion is because Github Actions have a great ecosystem of actions/plugins/and so on, better native integration with github repos (it's made by github itself, has "actions" tab in repo and so on) and a growing popularity and adoption, especially in open source projects. It's also free and works out-of-box very well 👍 🍻

@prodis
Copy link
Owner

prodis commented Aug 8, 2021

I see that GitHub Actions is trending, but you didn't mentioned any real advantage comparing to the current CI in Travis. In fact, the GitHub Actions configuration you proposed is missing the allowed failure Ruby versions and the cron jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants