Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt_BR yes or no (sim ou não) #13

Closed
wants to merge 2 commits into from
Closed

Conversation

ajmiciano
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 825fe97 on ajmiciano:master into b73bd1e on prodis:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 825fe97 on ajmiciano:master into b73bd1e on prodis:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 825fe97 on ajmiciano:master into b73bd1e on prodis:master.

@prodis prodis self-requested a review June 1, 2019 03:45
@prodis
Copy link
Owner

prodis commented Jun 1, 2019

@ajmiciano Thank you for your pull request.

Instead of adding Portuguese values directly to the list of valid boolean string representations, I'd suggest to create a configuration to customize the allowed values.

Something like:

WannabeBool.custom_string_values = {
  trues: ["sim"],
  falses: ["nao", "não"]
}

@prodis
Copy link
Owner

prodis commented Sep 14, 2021

@ajmiciano Don't you want to implement that feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants