Add header for build image in new pdc client output #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycheng-aa
force-pushed
the
PDC-1277_add_header_for_client_build_image
branch
from
11e66d5
to
3d33ffd
Compare
| fmt += ' {md5}' | ||
| fmt = '{image_id:50}{md5}' | ||
| print fmt.format(image_id='Image ID', md5='MD5') | ||
There was a problem hiding this comment.
why need to add a blank line ?
There was a problem hiding this comment.
For me it looks more clear. It also displayed like this way in compose-image-rtt-tests, compose-tree-locations. Not sure if this way is real better. @simozhan what do you think?
There was a problem hiding this comment.
i have the same idea. from the output, it is more clear to add a new line between the results and the title.
|
👍 |
|
Looks good to me. |
ycheng-aa
force-pushed
the
PDC-1277_add_header_for_client_build_image
branch
from
d23c41e
to
fa9eeb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: 1277