Add tests for message bus #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubomir
reviewed
Feb 27, 2018
pdc/apps/utils/__init__.py
Outdated
| messenger = MESSENGERS.get(settings.MESSAGE_BUS['MLP'], DummyMessenger)() | ||
|
|
||
| def _init_messenger(): | ||
| mpl = settings.MESSAGE_BUS['MLP'] |
There was a problem hiding this comment.
I think MPL stands for Messaging Library Provider. mpl looks like a typo.
pdc/settings_test.py
Outdated
| listener.messages.append((topic, msg)) | ||
|
|
||
| def listen(self): | ||
| return TestListener(self) |
There was a problem hiding this comment.
Should these two classes really be in the settings file? Maybe a comment explaining why would be useful.
There was a problem hiding this comment.
I could add special value "test" for the settings.MESSAGE_BUS['MLP'] and move the classes to pdc/apps/utils/messaging.py. That way I don't have to modify how the global messenger variable is initiated.
lubomir
approved these changes
Feb 28, 2018
hluk
force-pushed
the
test-message-bus
branch
from
619e86e
to
47e3434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it can be handled more directly by overriding
pdc.apps.utils.messengerinsettings_tests.py. Not sure which solution is cleaner.This is just single simple test, or more like proof of concept. It doesn't seem the message format is documented anywhere.
Perhaps this is enough for PDC-2583?