Dummy messenger should log the messages #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubomir
force-pushed
the
debug-messenger
branch
from
fe45dea
to
eee5e9c
Compare
hluk
reviewed
Feb 28, 2018
|
|
||
| def send_message(self, topic, msg): | ||
| pass | ||
| logger.info('Sending to %s:\n%s' % (topic, json.dumps(msg, sort_keys=True, indent=2))) |
There was a problem hiding this comment.
Right, it is. That will have to change probably.
hluk
approved these changes
Mar 1, 2018
For some messaging backends it may not be necessary to do the encoding (e.g. fedmsg), and it's simpler when creating the message.
Instead of ignoring them all, it should log them. This can be easily
disabled in the LOGGING settings by adding following snippet:
'pdc.apps.utils.messaging': {
'level': 'WARNING',
}
JIRA: PDC-2583
|
I added another commit that encodes the message to JSON only in the messenger. This saves us the parsing in Fedmsg, and will be needed for UMB to construct the headers based on message data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of ignoring them all, it should log them. This can be easily disabled in the LOGGING settings by adding following snippet:
JIRA: PDC-2583