This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Drop dependency on the jellyfish-mail package #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abstraction inside `jellyfish-mail` can be held entirely inside the `action-send-email` action, allowing us to archive the whole `jellyfish-mail` repo. Change-type: patch Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
It doesn't make sense to include the `buildSendEmailOptions` utility inside the `action-send-email` file, since its not actually used there. Change-type: patch Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
Change-type: patch Signed-off-by: Josh Bowling <josh@balena.io>
joshbwlng
reviewed
Feb 8, 2022
| @@ -81,13 +81,13 @@ const handler: ActionDefinition['handler'] = async ( | |||
| defaultEnvironment.mail.options | |||
| ) { | |||
| const client = new Mailgun(defaultEnvironment.mail.options); | |||
| const response = await client.sendEmail({ | |||
There was a problem hiding this comment.
This is an axios response object typed as any and therefore doesn't match what we expect to be returned from action handlers. null is the best option here as we aren't creating/updating contracts etc, we're just attempting to send an email through an external service.
joshbwlng
approved these changes
Feb 8, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abstraction inside
jellyfish-mailcan be held entirely inside theaction-send-emailaction, allowing us to archive the wholejellyfish-mailrepo.Change-type: patch
Signed-off-by: Lucian Buzzo lucian.buzzo@gmail.com