This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor pagination logic to be less complex #231
Draft
LucianBuzzo
wants to merge
7
commits into
master
Choose a base branch
from
pagination-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefKors
force-pushed
the
pagination-refactor
branch
from
February 9, 2021 10:05
42dd0ee
to
71386c5
Compare
Change-type: major Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
StefKors
force-pushed
the
pagination-refactor
branch
from
March 5, 2021 11:38
71386c5
to
937e2d0
Compare
Connects-to: product-os/autumndb#519 |
Proposed Pagination APIInitial page load
Paginating
Know issues / todo'sIn the PR's below I've commented and annotated what's still to be implemented and what's still not functioning 100% correctly. These are the two main aspects that haven't been implemented: Problem 1
So what happens is we set the schema Problem 22 browsers side by side:
Connects-to: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: major
Signed-off-by: Lucian Buzzo lucian.buzzo@gmail.com