You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR product-os/transformer-worker#494 updated a docker image from 0.18.1 to 0.19.0. NPM would consider this a major version change and the SemVer spec explicitly states that breaking changes might happen between 0.x releases.
Looking at this, I'm not sure if we need to change something or if this is a Renovate bug:
@Hades32 It would still be a patch bump in our repos, but I guess what you're suggesting is not auto approving and merging. I honestly wasn't aware that the semver spec allows for breaking changes in minors. If that is the case I suspect we might should put these in a separate renovate group and require humans to approve these bumps.
Yeah, it's a special case of 0.x.y versions. It also isn't implemented the same everywhere. NPM for example interprets 0.1 -> 0.2 as major and 0.1.1->0.1.2 as minor, whereas the spec makes no such guarantees for 0.x.y versions.
And yes, a manual approval is what I meant. TBH, there's still a chance that we would have missed that, but at least it would have been easier to find out what caused it
The PR product-os/transformer-worker#494 updated a docker image from 0.18.1 to 0.19.0. NPM would consider this a major version change and the SemVer spec explicitly states that breaking changes might happen between 0.x releases.
Looking at this, I'm not sure if we need to change something or if this is a Renovate bug:
renovate-config/renovate.json
Lines 38 to 46 in 3f0ad5c
The text was updated successfully, but these errors were encountered: