Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

structured logging #506

Merged
8 commits merged into from Jan 18, 2022
Merged

structured logging #506

8 commits merged into from Jan 18, 2022

Conversation

Hades32
Copy link
Contributor

@Hades32 Hades32 commented Jan 17, 2022

This changes the runtime to use structured logging, just like product-os/transformer-runtime#40 .

I also introduce a new linter rule to ensure nobody is using non-structured logging accidentally.

This should finally allow us to filter logs by PR (actually per commit).

When reviewing this, it makes sense to look at the individual commits, as some reformatting happened, too, because the linter wasn't enforced previously.

Martin Rauscher added 2 commits January 17, 2022 11:48
Signed-off-by: Martin Rauscher <martin@balena.io>
Signed-off-by: Martin Rauscher <martin@balena.io>
@ghost
Copy link

ghost commented Jan 17, 2022

Your landr site preview has been successfully deployed to https://landr-product-os-repo-transformer-worker-preview-506.netlify.app

Deployed with Landr 7.1.0

@Hades32 Hades32 force-pushed the h32/structured-logging branch 3 times, most recently from c41358f to dc30932 Compare January 17, 2022 17:54
@Hades32
Copy link
Contributor Author

Hades32 commented Jan 17, 2022

Copy link
Contributor

@stathismor stathismor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

transformer-runner/src/runner.ts Outdated Show resolved Hide resolved
transformer-runner/src/runner.ts Show resolved Hide resolved
transformer-runner/src/runner.ts Outdated Show resolved Hide resolved
Martin Rauscher added 4 commits January 18, 2022 15:49
Change-type: minor
Signed-off-by: Martin Rauscher <martin@balena.io>
Change-type: patch
Signed-off-by: Martin Rauscher <martin@balena.io>
Change-type: patch
Signed-off-by: Martin Rauscher <martin@balena.io>
Signed-off-by: Martin Rauscher <martin@balena.io>
Change-type: patch
Signed-off-by: Martin Rauscher <martin@balena.io>
@Hades32
Copy link
Contributor Author

Hades32 commented Jan 18, 2022

@balena-ci I self-certify!

@ghost ghost merged commit ebd0e21 into master Jan 18, 2022
@ghost ghost deleted the h32/structured-logging branch January 18, 2022 15:04
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants