This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Rauscher <martin@balena.io>
Signed-off-by: Martin Rauscher <martin@balena.io>
Your landr site preview has been successfully deployed to https://landr-product-os-repo-transformer-worker-preview-506.netlify.app Deployed with Landr 7.1.0 |
Hades32
force-pushed
the
h32/structured-logging
branch
3 times, most recently
from
January 17, 2022 17:54
c41358f
to
dc30932
Compare
Built successfully https://dashboard.balena-cloud.com/fleets/1780230/releases/2041032 |
Hades32
force-pushed
the
h32/structured-logging
branch
from
January 18, 2022 08:53
09fdf52
to
3b7370a
Compare
stathismor
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hades32
force-pushed
the
h32/structured-logging
branch
from
January 18, 2022 14:37
aef3d59
to
08900f9
Compare
Change-type: minor Signed-off-by: Martin Rauscher <martin@balena.io>
Change-type: patch Signed-off-by: Martin Rauscher <martin@balena.io>
Change-type: patch Signed-off-by: Martin Rauscher <martin@balena.io>
Signed-off-by: Martin Rauscher <martin@balena.io>
Hades32
force-pushed
the
h32/structured-logging
branch
from
January 18, 2022 14:50
aebaa87
to
b0f7cc5
Compare
Change-type: patch Signed-off-by: Martin Rauscher <martin@balena.io>
Hades32
force-pushed
the
h32/structured-logging
branch
from
January 18, 2022 14:51
1bbe918
to
d676867
Compare
@balena-ci I self-certify! |
ghost
approved these changes
Jan 18, 2022
ghost
deleted the
h32/structured-logging
branch
January 18, 2022 15:04
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the runtime to use structured logging, just like product-os/transformer-runtime#40 .
I also introduce a new linter rule to ensure nobody is using non-structured logging accidentally.
This should finally allow us to filter logs by PR (actually per commit).
When reviewing this, it makes sense to look at the individual commits, as some reformatting happened, too, because the linter wasn't enforced previously.