This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
fix: Support of new select API for all rules
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for it and also for extending test suit case. 💪 |
jukben
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging the
rfc: Objects as arguments in selectors, I updated theselectors-formatrule to match the newselectAPI.Unfortunately, I missed another two rules, which work with
select, resulting in insufficient linting.Reported by @tomsvob: https://github.com/productboard/pb-frontend/pull/7914#discussion_r419274033
In this PR I am implementing the support of the new
selectAPI for these 2 remaining lint rules.Also, I introduced
utils/connectUtilsandutils/selectUtilsto unify some common logic of detectingconnect/selectCallExpressions.And also there are quite a lot of syntax changes, as I ran prettier on the existing files, which were not prettified before.
💡Idea: Let's introduce official
prettiersupport for this repo?Edit: I see we already track this (#51)