Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add textarea support for contain assertions #63

Merged
merged 1 commit into from
Apr 23, 2016
Merged

Add textarea support for contain assertions #63

merged 1 commit into from
Apr 23, 2016

Conversation

ayrton
Copy link
Contributor

@ayrton ayrton commented Apr 22, 2016

Fixes #59

@vesln
Copy link
Contributor

vesln commented Apr 22, 2016

👍

1 similar comment
@andreasklinger
Copy link

👍

@ljharb
Copy link
Collaborator

ljharb commented Apr 22, 2016

We may also want special support for "select" elements, whose "value" should really be the value of the option matching the selected index

@ayrton
Copy link
Contributor Author

ayrton commented Apr 23, 2016

@ljharb good thinking! I'll create a different PR (hopefully next Friday)

@ayrton ayrton merged commit cd5307b into master Apr 23, 2016
@ayrton ayrton deleted the bugfix/textarea-contain branch April 23, 2016 09:25
@ayrton ayrton mentioned this pull request Apr 23, 2016
Closed
@danielbachhuber
Copy link

💯

@ayrton ayrton mentioned this pull request May 30, 2016
Closed
@ayrton ayrton added the feature label Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ayrton @vesln @andreasklinger @ljharb @danielbachhuber