Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up requirements #1372

Merged
merged 8 commits into from
Jan 31, 2023
Merged

fix up requirements #1372

merged 8 commits into from
Jan 31, 2023

Conversation

hrnciar
Copy link
Contributor

@hrnciar hrnciar commented Jun 17, 2021

No description provided.

@jamesmkrieger
Copy link
Contributor

Are you sure this is only needed for Python 2.7?

@hrnciar
Copy link
Contributor Author

hrnciar commented Jun 24, 2021

Oh seems like I edited the wrong line. It should be the other way around. I am not sure if it applies also to Python 2.7, though.

@jamesmkrieger
Copy link
Contributor

Ok. I’ll try and check it. Thanks

@jamesmkrieger jamesmkrieger marked this pull request as draft March 2, 2022 16:38
@jamesmkrieger
Copy link
Contributor

why do we need setuptools anyway?

@jamesmkrieger
Copy link
Contributor

I've updated it and it works now as follows:

$ pip install -Ue .
Obtaining file:///mnt/c/Users/james/code/scipion3_new/software/em/ProDy
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Requirement already satisfied: biopython in /home/jkrieger/anaconda3/envs/scipion3/lib/python3.8/site-packages (from ProDy==2.3.1) (1.79)
Requirement already satisfied: pyparsing in /home/jkrieger/anaconda3/envs/scipion3/lib/python3.8/site-packages (from ProDy==2.3.1) (3.0.7)
Requirement already satisfied: setuptools in /home/jkrieger/anaconda3/envs/scipion3/lib/python3.8/site-packages (from ProDy==2.3.1) (60.9.3)
Requirement already satisfied: scipy in /home/jkrieger/anaconda3/envs/scipion3/lib/python3.8/site-packages (from ProDy==2.3.1) (1.8.0)
Requirement already satisfied: numpy<1.24,>=1.10 in /home/jkrieger/anaconda3/envs/scipion3/lib/python3.8/site-packages (from ProDy==2.3.1) (1.18.4)
Building wheels for collected packages: ProDy
  Building editable for ProDy (pyproject.toml) ... done
  Created wheel for ProDy: filename=ProDy-2.3.1-0.editable-cp38-cp38-linux_x86_64.whl size=6588 sha256=9ac2e1a3590e104dc67ea48f2683b168b109d6faaaa588c9c2cb39788678bb74
  Stored in directory: /tmp/pip-ephem-wheel-cache-dmwx6c8a/wheels/50/74/d2/00fc92a611f32f30444b5a6a0435bcca8042b3b835e7c3984d
Successfully built ProDy
Installing collected packages: ProDy
  Attempting uninstall: ProDy
    Found existing installation: ProDy 2.3.1
    Uninstalling ProDy-2.3.1:
      Successfully uninstalled ProDy-2.3.1
Successfully installed ProDy-2.3.1

everything works fine without as far as I can tell too though

@jamesmkrieger
Copy link
Contributor

the answer may actually be that it's already in pyproject.toml

@jamesmkrieger
Copy link
Contributor

probably this is the good way to do it now

@jamesmkrieger jamesmkrieger changed the title Require setuptools, prody/utilities/misctools.py imports pkg_resources fix up requirements Jan 31, 2023
@jamesmkrieger jamesmkrieger marked this pull request as ready for review January 31, 2023 18:09
@jamesmkrieger jamesmkrieger merged commit ced2e74 into prody:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants