Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size is being treated as string size #38

Closed
mjfavaro opened this issue Aug 1, 2015 · 4 comments
Closed

File size is being treated as string size #38

mjfavaro opened this issue Aug 1, 2015 · 4 comments
Labels
Milestone

Comments

@mjfavaro
Copy link

mjfavaro commented Aug 1, 2015

File size is being treated as string size

When validates laravel
"The logo may not be greater than 100 kilobytes."

When validates javascript
"The logo may not be greater than 100 characters."

@torrentalle torrentalle added the bug label Aug 2, 2015
@torrentalle
Copy link
Member

Can you post your validation rules?

@torrentalle torrentalle added this to the 1.1.0 milestone Aug 3, 2015
@mjfavaro
Copy link
Author

mjfavaro commented Aug 3, 2015

I'm using
Laravel 5.1
laravel-jsvalidation 1.0

My form request:
public function rules()
{
return [
'domain' => 'required|domain',
'name' => 'required|max:255',
'logo' => 'image|size:100',
];
}

Congratulations for this package, is the best package :)

torrentalle pushed a commit that referenced this issue Aug 3, 2015
@torrentalle
Copy link
Member

Thank's.
I found the bug. I will publish it shortly, I'm preparing new release

@torrentalle
Copy link
Member

This bug is fixed in master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants