Partially fixes #229 #312
Merged
Partially fixes #229 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 20, 2018
| @@ -160,7 +160,7 @@ laravelValidation = { | |||
|
|
|||
| var param = typeof param === "string" && { url: param } || param; | |||
|
|
|||
| if ( previous.old === value ) { | |||
| if (laravelValidation.helpers.arrayEquals(previous.old, value) || previous.old === value) { | |||
|
I've created branch v1. Sorry I don't have enough time to test and merge it now. Could anybody confirm that this fix solves an issue? |
|
@bytestream could you resolve conflicts to make it mergeable, please? Additionally you could run gulp with |
|
@a-komarev done |
|
@bytestream great, thanks! Have you tested it? Because I've tested only 1st part of your solution and merged it because its working well. |
|
@a-komarev it resolved the issue I was having but I haven't tested it extensively |
|
I'll merge it to allow you, @derekmd and other people who has same issue to test it on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See second issue described here #229 (comment)
Assuming you're happy with this I would appreciate if I can also copy to v1. Please could you create a v1 branch or copy this yourself?