Ability to escape validation messages #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytestream
force-pushed
the
escape-output
branch
from
59528aa
to
021ec23
Compare
|
@torrentalle @antonkomarev @drjoju Can any of you access the StyleCI account linked to this repository? StyleCI team are advising that in-app settings are overriding the |
|
I've tried to fix StyleCI somehow and even wrote to StyleCI staff for helping me to fix that, but only @torrentalle has access to it. |
|
@drjoju sorry to ping, but while you're active would you mind looking at this comment? #329 (comment) maybe you have permission to edit the account... |
bytestream
force-pushed
the
escape-output
branch
from
e1b2480
to
e2dfa47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spoke to @torrentalle about this a while ago. If you inject database values into validation messages then you can leave leave yourself open to XSS attacks, for example consider custom field usage.
This adds a new escape configuration option that will run
htmlentitieson all validation messages. By default it's turn offed for backwards compatibility...