Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 5.8 #373

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Support Laravel 5.8 #373

merged 2 commits into from
Mar 12, 2019

Conversation

sangnguyenplus
Copy link
Contributor

No description provided.

@Braunson
Copy link
Contributor

Braunson commented Mar 1, 2019

Can we get this merged @proengsoft?

@mgkprod
Copy link

mgkprod commented Mar 7, 2019

👍

@mathiasonea
Copy link

mathiasonea commented Mar 11, 2019

Hey, do you guys know what went wrong in the StyleCI Check?
It states that the analysis was misconfigured. How can we configure it correctly so that we can build version 2.4?

@sangnguyenplus according to this StyleCI Check, the "linting" Option provided was invalid.
Linting was removed from the StyleCI option list in april 2018..

@gwleuverink
Copy link

@torrentalle @proengsoft Any chance you can take a look at this PR?

@gwleuverink
Copy link

gwleuverink commented Mar 11, 2019

For the time being, anyone who'd like to install v2.4.0 add the following to your composer.json:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/sangnguyenplus/laravel-jsvalidation.git"
        }
    ],

And then add the following line in your require section: "proengsoft/laravel-jsvalidation": "^2.4",

This is a temporary solution tough.

@drjoju drjoju merged commit b2dfa9e into proengsoft:master Mar 12, 2019
@mathiasonea
Copy link

thank you, @drjoju !
now we only need a new release 2.4.0 and we are done here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants