Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #297 #432

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Fixes #297 #432

merged 2 commits into from
Apr 19, 2020

Conversation

bytestream
Copy link
Collaborator

@bytestream bytestream commented Apr 16, 2020

Description

Laravel validation converts * to __asterisk__ in Laravel 6+ (laravel/framework#31257).

helpers.js relies on [*] to parse those wildcard rules:

regexFromWildcard: function(name) {
      var nameParts = name.split("[*]");

Todo:

  • Find a solution for Laravel 5.6 - 5.8 or bump the minimum version to 6.0+
  • Add tests

@bytestream bytestream linked an issue Apr 17, 2020 that may be closed by this pull request
@bytestream bytestream marked this pull request as ready for review April 19, 2020 12:58
@bytestream bytestream merged commit f504083 into proengsoft:master Apr 19, 2020
@bytestream bytestream deleted the #297 branch April 19, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multidimensional array wildcard validation
1 participant