Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated phpjs #445

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Updated phpjs #445

merged 2 commits into from
Jun 12, 2020

Conversation

bytestream
Copy link
Collaborator

Description

Updates phpjs to the latest version.

import strlen from 'locutus/php/strings/strlen';
import array_diff from 'locutus/php/array/array_diff';
import strtotime from 'locutus/php/datetime/strtotime';
import is_numeric from 'locutus/php/var/is_numeric';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Identifier 'is_numeric' is not in camel case.

@@ -9,6 +9,11 @@
* Released under the MIT license
*/

import strlen from 'locutus/php/strings/strlen';
import array_diff from 'locutus/php/array/array_diff';
import strtotime from 'locutus/php/datetime/strtotime';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@@ -9,6 +9,11 @@
* Released under the MIT license
*/

import strlen from 'locutus/php/strings/strlen';
import array_diff from 'locutus/php/array/array_diff';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Identifier 'array_diff' is not in camel case.

@@ -9,6 +9,11 @@
* Released under the MIT license
*/

import strlen from 'locutus/php/strings/strlen';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@bytestream bytestream linked an issue Apr 26, 2020 that may be closed by this pull request
@bytestream bytestream added bug needs-review Waiting for feedback. labels Apr 26, 2020
@bytestream bytestream removed the needs-review Waiting for feedback. label Jun 12, 2020
@bytestream
Copy link
Collaborator Author

ES6 is permitted in these sources though does not appear to currently exist. Need to transpile to ES5.

@bytestream
Copy link
Collaborator Author

ES6 is permitted in these sources though does not appear to currently exist. Need to transpile to ES5.

Seems it's not necessary.

This function targets ES5, but as of Locutus 2.0.2 we also support ES6 functions. Locutus transpiles to ES5 before publishing to npm.
https://locutus.io/php/var/is_numeric/

@bytestream bytestream merged commit 9fe07b0 into proengsoft:master Jun 12, 2020
@bytestream bytestream deleted the phpjs branch June 15, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated phpjs implementation
2 participants